Repository navigation
test(agc): map GPU memory on fibers with and without a host stack - #6993
Merged
oneandonlydean merged 1 commit intoOct 17, 2026
Merged
Conversation
Since boykopovar#6003 a fiber with a context of 64 KiB or more runs on the context itself, so the 64 KiB fiber of agc_driver_gpu_map_on_fiber imports its mapping on a host thread on Windows too, and the test's Windows-only expectation of no thread failed. The test now also maps on a 16 KiB fiber, which keeps a host stack and imports on it on Windows, and expects one import thread for the 64 KiB fiber on every platform. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Confirmed on NVIDIA and Intel too: i7-13700K, RTX 4080 (617.42) and Intel UHD 770 (101.6129), Windows, WinLibs GCC 15.2.0, Release,
AI-assisted: yes (Claude Code) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
agc_driver_gpu_map_on_fiberfails on Windows on currentmainwith a Vulkan device:The test runs its fiber on a 64 KiB context. Since #6003 a fiber gets a host stack only when its context is smaller than 64 KiB (
size_context < FIBER_GUEST_STACK_MIN), so this fiber now runs on the context itself on Windows too.StackHoldsImportfinds less than 256 KiB of stack and the driver imports the mapping on a host thread, which is correct; the Windows-only expectation of no thread came from 8136438, when every Windows fiber had a host stack.The test now maps on two fibers:
Both still check that the import used at most 8 KiB of the fiber's context, and the mapping on an ordinary thread still starts no thread.
CI does not show the failure: in run 38993324986 (
mainf643e61d9, after #6003) Windows builds the test asExecutionTestNotBuilt.cppand skips it, and Linux, which already expected one thread, passes.Tested
Windows 11 26200, AMD Radeon RX 6700 XT (driver 32.0.21045.5002), WinLibs GCC 15.2.0 r7, Release,
BUILD_TESTING=ON,ANYPS5_REQUIRE_VULKAN=1, onmain9bf01db66:main: fails 3/3 with the line above.A GPU mapping made on a fiber used 0 bytes of its context with a host stack and 3104 running on the context);fiberpasses.size_context < FIBER_GUEST_STACK_MINcondition removed locally: fails withGPU mapping on a fiber running on its context started 0 host threads for its import instead of one, so the test follows fix(libSceFiber): run a fiber on its own context when the context is large #6003's limit.ctest --parallel 4 --timeout 120onmain: 1352 tests, 3 fail: this one,agc_driver_lds_mixed_width_atomics(agc_* tests: 3 of 483 fail on AMD Radeon RX 6400, pass on NVIDIA RTX 4080 SUPER #5271) andagc_driver_layered_volume_vertex_no_gpl(AMD Windows: GPL-mode cache failures (alpha/wave32 pass after local driver update) #4768, fixed by fix(agc): key shader modules by the pipeline library mode #6436).python tools/check_conventions.py --base origin/mainwith this title and body passes.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)🤖 Generated with Claude Code