Skip to content

docs(debt): record libSceVoiceQoS endpoint stubs as unknown signatures - #7012

Closed
mohammad-alosta wants to merge 2 commits into
boykopovar:mainfrom
mohammad-alosta:docs/libSceVoiceQoS-endpoint-stubs
Closed

mohammad-alosta wants to merge 2 commits into
boykopovar:mainfrom
mohammad-alosta:docs/libSceVoiceQoS-endpoint-stubs

Conversation

@mohammad-alosta

@mohammad-alosta mohammad-alosta commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

What

docs(debt): record remaining libSceVoiceQoS throwing stubs as unknown signatures

Documents five throwing stubs in core/libs/prx/libSceVoiceQoS/Export.cpp
that are declared without parameters with unknown signatures:

  • sceVoiceQoSSetConnectionAttribute
  • sceVoiceQoSSetRemoteEndpointAttribute
  • sceVoiceQoSReadPacket
  • sceVoiceQoSWritePacket
  • sceVoiceQoSGetLocalEndpointAttribute

All are declared without parameters with unknown signatures; every call
throws via NotImplemented_nid_no_patch before returning. PPSA04159
imports them and fails to load without them. Per CONTRIBUTING, unknown
signatures belong in debt rather than made-up implementations.

Seven other endpoint calls in the same library were implemented since
the original debt entry was written (sceVoiceQoSCreateLocalEndpoint,
sceVoiceQoSDeleteLocalEndpoint, sceVoiceQoSCreateRemoteEndpoint,
sceVoiceQoSDeleteRemoteEndpoint, sceVoiceQoSConnect,
sceVoiceQoSDisconnect, sceVoiceQoSSetLocalEndpointAttribute), so the
sceVoiceQoSInit entry's "other endpoint and packet calls remain
throwing stubs" now refers specifically to these five.

No core/ code is changed.

Tested

  • python3 tools/check_conventions.py --base origin/main — all conventions checks passed
  • python3 tools/tests/test_progress.py — 14 tests OK

Checklist

  • Based on current main; no other open PR implements the same functions
  • One topic per PR; follow-ups go in a new PR
  • No comments in code except technical debt
  • Unimplemented paths throw (NotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file
  • No notes, investigation .md files or images added to the repository (attach them to this PR)
  • New third-party code is a submodule built from source
  • Generic behaviour, not specific to one title
  • Depends on: none
  • Unblocks: none
  • GPUs tested: n/a
  • AI-assisted: yes

@github-actions github-actions Bot added docs needs rebase Conflicts with main, rebase needed labels Oct 17, 2026
@blawesom

Copy link
Copy Markdown
Contributor

Rebase handoff — rebased onto current main cleanly (single docs commit, authorship unchanged): the libSceVoiceQoS endpoint-stub debt entry.

Verified on Linux (CachyOS, kernel 7.2.9, GCC 16.2.1, Ninja, Release, BUILD_TESTING=ON, AMD RX 9070 XT / RADV):

To pick it up:

git fetch https://github.com/blawesom/AnyPS5 rebase/7012
git checkout <your branch>
git merge --ff-only FETCH_HEAD

Head is 4519c79ed.

… signatures

Documents five throwing stubs in core/libs/prx/libSceVoiceQoS/Export.cpp
that are declared without parameters with unknown signatures:
sceVoiceQoSSetConnectionAttribute, sceVoiceQoSSetRemoteEndpointAttribute,
sceVoiceQoSReadPacket, sceVoiceQoSWritePacket and
sceVoiceQoSGetLocalEndpointAttribute. PPSA04159 imports them and fails
to load without them. No reference gives their argument lists.

Seven other endpoint calls in the same library were implemented since
the original debt entry was written, so the sceVoiceQoSInit entry's
"other endpoint and packet calls remain throwing stubs" now refers
specifically to these five.

No core library code is changed.

Tested: check_conventions.py passes, test_progress.py passes.

AI-assisted: yes
@mohammad-alosta
mohammad-alosta force-pushed the docs/libSceVoiceQoS-endpoint-stubs branch from ac11265 to 7199f7e Compare October 17, 2026 14:15
@github-actions github-actions Bot removed the needs rebase Conflicts with main, rebase needed label Oct 17, 2026
@github-actions github-actions Bot added the needs rebase Conflicts with main, rebase needed label Oct 17, 2026
@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.

Pull request Shared files not compared
PR 7727 docs/dev/debt/libSceVoiceQoS.md

@adriadam10 adriadam10 self-assigned this Oct 19, 2026

@adriadam10 adriadam10 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked against current main:

  • sceVoiceQoSSetRemoteEndpointAttribute is no longer a throwing stub: Export.cpp:143 implements it as (remoteId, attributeId, value, size). The new debt entry saying it is declared without parameters and its signature is unknown is wrong; please drop it.
  • sceVoiceQoSReadPacket, sceVoiceQoSWritePacket and sceVoiceQoSGetLocalEndpointAttribute are still stubs, but #7321 and #7727 are open and implement them, and both edit docs/dev/debt/libSceVoiceQoS.md. These entries would go stale or conflict as soon as either merges; please either coordinate with those PRs or wait for them.
  • The branch conflicts with main in the debt file; please rebase after the above.
  • "verified against the built libSceVoiceQoS.prx export table" cannot be checked from the PR; please attach that output or drop the claim.

@mohammad-alosta
mohammad-alosta marked this pull request as draft October 20, 2026 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs needs rebase Conflicts with main, rebase needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants