Repository navigation
docs(debt): record libSceVoiceQoS endpoint stubs as unknown signatures - #7012
Closed
mohammad-alosta wants to merge 2 commits into
Closed
mohammad-alosta wants to merge 2 commits into
mohammad-alosta wants to merge 2 commits into
Conversation
Contributor
|
Rebase handoff — rebased onto current Verified on Linux (CachyOS, kernel 7.2.9, GCC 16.2.1, Ninja, Release,
To pick it up: Head is |
… signatures Documents five throwing stubs in core/libs/prx/libSceVoiceQoS/Export.cpp that are declared without parameters with unknown signatures: sceVoiceQoSSetConnectionAttribute, sceVoiceQoSSetRemoteEndpointAttribute, sceVoiceQoSReadPacket, sceVoiceQoSWritePacket and sceVoiceQoSGetLocalEndpointAttribute. PPSA04159 imports them and fails to load without them. No reference gives their argument lists. Seven other endpoint calls in the same library were implemented since the original debt entry was written, so the sceVoiceQoSInit entry's "other endpoint and packet calls remain throwing stubs" now refers specifically to these five. No core library code is changed. Tested: check_conventions.py passes, test_progress.py passes. AI-assisted: yes
mohammad-alosta
force-pushed
the
docs/libSceVoiceQoS-endpoint-stubs
branch
from
October 17, 2026 14:15
ac11265 to
7199f7e
Compare
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
adriadam10
requested changes
Oct 19, 2026
adriadam10
left a comment
Collaborator
There was a problem hiding this comment.
Checked against current main:
sceVoiceQoSSetRemoteEndpointAttributeis no longer a throwing stub:Export.cpp:143implements it as(remoteId, attributeId, value, size). The new debt entry saying it is declared without parameters and its signature is unknown is wrong; please drop it.sceVoiceQoSReadPacket,sceVoiceQoSWritePacketandsceVoiceQoSGetLocalEndpointAttributeare still stubs, but #7321 and #7727 are open and implement them, and both editdocs/dev/debt/libSceVoiceQoS.md. These entries would go stale or conflict as soon as either merges; please either coordinate with those PRs or wait for them.- The branch conflicts with
mainin the debt file; please rebase after the above. - "verified against the built
libSceVoiceQoS.prxexport table" cannot be checked from the PR; please attach that output or drop the claim.
mohammad-alosta
marked this pull request as draft
October 20, 2026 02:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
docs(debt): record remaining libSceVoiceQoS throwing stubs as unknown signatures
Documents five throwing stubs in
core/libs/prx/libSceVoiceQoS/Export.cppthat are declared without parameters with unknown signatures:
All are declared without parameters with unknown signatures; every call
throws via
NotImplemented_nid_no_patchbefore returning. PPSA04159imports them and fails to load without them. Per CONTRIBUTING, unknown
signatures belong in debt rather than made-up implementations.
Seven other endpoint calls in the same library were implemented since
the original debt entry was written (sceVoiceQoSCreateLocalEndpoint,
sceVoiceQoSDeleteLocalEndpoint, sceVoiceQoSCreateRemoteEndpoint,
sceVoiceQoSDeleteRemoteEndpoint, sceVoiceQoSConnect,
sceVoiceQoSDisconnect, sceVoiceQoSSetLocalEndpointAttribute), so the
sceVoiceQoSInitentry's "other endpoint and packet calls remainthrowing stubs" now refers specifically to these five.
No
core/code is changed.Tested
python3 tools/check_conventions.py --base origin/main— all conventions checks passedpython3 tools/tests/test_progress.py— 14 tests OKChecklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)