Repository navigation
fix(agc): exclude neighboring stores from DCC invalidation - #7132
Conversation
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
|
First independent GPU run of this head (the PR lists author-reported runs only): head
The neighboring-store cases in the updated |
|
Thanks for the independent GPU validation. This adds a second hardware report: the focused alpha-to-coverage/sample-mask/sample-multisample group passed 4/4 on both an RTX 3070 and Intel UHD 630, including the neighboring-store cases. I’ll keep the PR’s validation summary aligned with the distinction between these independent runs and the issue author’s broader title testing. |
|
Thanks for testing the exact head on both NVIDIA and Intel. The four focused cases pass on each device, including the neighboring-store regression cases; this is useful independent confirmation of the reported DCC invalidation behavior. |
|
Thanks for the first independent GPU run on this head. The RTX 3070 and UHD 630 results confirm the updated neighboring-store regression cases pass on both NVIDIA and Intel; I have recorded the exact device and driver scope. |
|
@MarcZX100 thank you for carrying the three original commits unchanged with attribution. Our source audit confirms that exact e040/#7132 is already active in current integrationc784. The latest Sonic validation distinguishes the remaining stop from the adjacent-store case: public-source observers7b/78db record These are current-integration observations, not new exact-PR-head results; the original e040 hardware validation retains its original pin. The observer builds pass on both OSes and its existing2x/4x/8x positive/refusal controls pass18 times across NVIDIA/AMD, plus6 Linux controls. This does not reduce the independently reproduced neighboring-store correction or establish a shared Ruffle/AMD cause. |
|
Thanks for tracing the remaining Sonic rejection to a newer driver-overlap piece in |
|
A title data point for this PR. Ruffle (PPSA68091) on Linux, RTX 4070 Ti (NVIDIA 595.99.02), 60 s with scripted pad input. Base is
A local print there showed the DCC range AI-assisted: yes (Claude Code) |
|
Thanks for the independent Ruffle run on the PR head. The base/+PR comparison and the reported |
What
Retain the existing unchanged-generation proof when resolving resident multisampled DCC targets, while accepting the finer
StoredOverproof for unrelated stores within the same tracking block. Keep refusing actual overlapping writes and uncertain or evicted fine-grained history. Includes the focused adjacent-store regression.Tested
Linux x86_64, GCC 12.2: CMake Release configure succeeded. The focused fixture and AGC driver build stopped before compiling changed files at the unrelated existing
SrtDescriptorEvaluation.cpptemplate parse error.git diff --checkpassed. Candidate author reports 18 physical-GPU fixture passes (RTX 5080 and AMD Radeon Graphics) plus llvmpipe coverage at the exact candidate commit in issue #5336; these are author-reported results, not run in this environment.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)Carries the three original commits by Romans Pokrovskis unchanged:
975c3ee6b3,6eebcc2ce1, ande040cb7f75. The neighboring-store failure is separately reproduced; its causal relationship to the title failures in #5336 remains unknown.