Skip to content

ci(build): build the pull requests in the register context and write watch jobs - #7205

Merged
oneandonlydean merged 1 commit into
boykopovar:mainfrom
wachi35676:fix/ci-context-jobs-build-dispatched-pr
Oct 17, 2026
Merged

oneandonlydean merged 1 commit into
boykopovar:mainfrom
wachi35676:fix/ci-context-jobs-build-dispatched-pr

Conversation

@wachi35676

Copy link
Copy Markdown
Contributor

What

The register-context and write-watch jobs in .github/workflows/build.yml check out with a bare actions/checkout@v7, so a manual (workflow_dispatch) build compiles and tests main instead of the selected pull requests. That happens even though the gate starts these jobs because a pull request touched their files: registerContext and writeWatch include libc.

Example: run 39048834802 builds #7187, which changes libc.

  • register-context (macos-15-intel, Release): fetches only +66702f1c…:refs/remotes/origin/main, runs checkout -B main, and builds 66702f1 without the PR. Its "success" says nothing about fix(libc): open long Windows host paths #7187.
  • Relinker job, same run: fetches refs/pull/7187/head and logs Merge made by the 'ort' strategy.

Both jobs now start with the same two steps as the relinker, Linux and Windows jobs: check out the gate's main commit (needs.eligibility.outputs.sha), then run "Merge the pull request into main". That step is copied verbatim from the relinker job, including the loop over several pull requests and the stale-head and conflict errors. On push events head is empty, so the merge step is skipped as in the other jobs.

Tested

  • The workflow parses (yaml.safe_load). The first two steps of relinker, register-context and write-watch are now identical.
  • The merge step uses shell: bash and only constructs already used on the macOS runners by the relinker job, which runs on macos-latest. write-watch runs on macos-15-intel and macos-15.
  • I cannot dispatch the workflow from a fork, so it has not been run.
  • python tools/check_conventions.py --base origin/main passes.

Overlap: #3962 also edits the register-context job (its matrix and configure line) and conflicts textually with this change; whichever lands second needs a small rebase. #7096, #7097, #7197 and #6932 merge cleanly with it.

Checklist

  • Based on current main; no other open PR implements the same functions
  • One topic per PR; follow-ups go in a new PR
  • No comments in code except technical debt
  • Unimplemented paths throw (NotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file
  • No notes, investigation .md files or images added to the repository (attach them to this PR)
  • New third-party code is a submodule built from source
  • Generic behaviour, not specific to one title
  • Depends on: none
  • Unblocks: none
  • GPUs tested: n/a
  • AI-assisted: yes

🤖 Generated with Claude Code

…watch jobs

Both jobs checked out without a ref, so a dispatched build compiled and
tested main instead of the selected pull requests, although the gate
starts them because a pull request touched their files. They now check
out the gate's main commit and merge the pull requests with the same
step as the relinker, Linux and Windows jobs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added the ci .github label Oct 17, 2026
@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.

Pull request Conflicting files (lines on main) Same exports Same new files
PR 3962 .github/workflows/build.yml L361-362, L376-377

Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.

Pull request Shared files not compared
PR 6044 .github/workflows/build.yml
PR 7096 .github/workflows/build.yml

@oneandonlydean
oneandonlydean merged commit e761af9 into boykopovar:main Oct 17, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci .github

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants