Repository navigation
ci(build): build the pull requests in the register context and write watch jobs - #7205
Merged
oneandonlydean merged 1 commit intoOct 17, 2026
Conversation
…watch jobs Both jobs checked out without a ref, so a dispatched build compiled and tested main instead of the selected pull requests, although the gate starts them because a pull request touched their files. They now check out the gate's main commit and merge the pull requests with the same step as the relinker, Linux and Windows jobs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
11 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
register-contextandwrite-watchjobs in.github/workflows/build.ymlcheck out with a bareactions/checkout@v7, so a manual (workflow_dispatch) build compiles and testsmaininstead of the selected pull requests. That happens even though the gate starts these jobs because a pull request touched their files:registerContextandwriteWatchinclude libc.Example: run 39048834802 builds #7187, which changes libc.
register-context (macos-15-intel, Release): fetches only+66702f1c…:refs/remotes/origin/main, runscheckout -B main, and builds66702f1without the PR. Its "success" says nothing about fix(libc): open long Windows host paths #7187.refs/pull/7187/headand logsMerge made by the 'ort' strategy.Both jobs now start with the same two steps as the relinker, Linux and Windows jobs: check out the gate's
maincommit (needs.eligibility.outputs.sha), then run "Merge the pull request into main". That step is copied verbatim from the relinker job, including the loop over several pull requests and the stale-head and conflict errors. Onpusheventsheadis empty, so the merge step is skipped as in the other jobs.Tested
yaml.safe_load). The first two steps ofrelinker,register-contextandwrite-watchare now identical.shell: bashand only constructs already used on the macOS runners by the relinker job, which runs onmacos-latest.write-watchruns onmacos-15-intelandmacos-15.python tools/check_conventions.py --base origin/mainpasses.Overlap: #3962 also edits the
register-contextjob (its matrix and configure line) and conflicts textually with this change; whichever lands second needs a small rebase. #7096, #7097, #7197 and #6932 merge cleanly with it.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)🤖 Generated with Claude Code