Repository navigation
docs(dev): name the memory budgets and the sleeping-display stop in the game testing guide - #8135
Conversation
|
Thanks, this is useful: the budget lines and when to report them belong in the guide. One change, please: we don't name specific titles in the docs, so could you drop the sentence with the game and level example? The general description of thousands of evictions per 10 s at the 2048 MiB floor already says it. Per-game findings go in the Game bring-up discussions. |
…he game testing guide Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BywPXoZACVi8ALV4JKvuPZ
3a50692 to
bb864e8
Compare
|
@oneandonlydean done in bb864e8: the sentence with the title example is gone; the general description of the evictions at the 2048 MiB floor stays. AI-assisted; the runs are from my machine(s). |
MarcZX10
left a comment
There was a problem hiding this comment.
The additions match current source and documentation: the host-import refusal line is emitted only from the refusal path, texture-cache budget lines are produced by the documented profiling path, and the sleep-related SDL display-index error is formed at the VideoOut call site. The check_main_sync.py --fetch command exists and fetches the selected remote-tracking main before reporting ahead/behind/conflicts. The maintainer’s request to remove title-specific examples from the guide has been addressed. Conventions, eligibility and labels pass; the product jobs are correctly skipped for this docs-only change. I reran the overlap checker against the current open PR queue (1,105 PRs); it reports no overlap. No documentation defect found; approved.
|
@mrfelek thanks for dropping that sentence. The guide reads well now, and every variable and log line it names still matches current main. I've passed it on for merge. |
What
Three additions to
docs/dev/GAME_TESTING.md(#6627), from runs since it merged:[gpu] host import budget: ... refused so far(printed only when an import is refused, at most every 10 s),[gpu] sampled texture cache budget, and the[texture-cache] (10 s)line withAPS5_PROFILE_DRAW=1. It linksAPS5_HOST_IMPORT_MIB(ENVIRONMENT) andAPS5_TEXTURE_CACHE_MIB(USAGE, Texture cache budget). Examples from the discussions: ASTRO BOT is about 2.5× slower on 32 GiB machines at fix(agc): keep half the host heap out of the host import budget #6472's import budget (EdouardSence on Astro Bot (PPSA21564) #357 and fix(agc): keep at most 4 GiB of the host heap from the host import budget #7844), and Sky Garden on a 12 GB card loses about two thirds of its frame rate at the 2048 MiB texture budget floor (Astro Bot (PPSA21564) #357). "Reporting a result" item 6 now asks for these lines too.SDL_GetWindowDisplayIndex failed: Couldn't find any displays(VideoOutDriver.cpp); keep the display awake for long or unattended runs.tools/check_main_sync.py --fetch(under "Before a run"): reports whether the branch is in step with upstreammain, so a result isn't taken on an old base by mistake.Tested
Not tested beyond the docs:
tools/check_conventions.py --base origin/mainpasses (it checks the links), andtools/pr_overlap.pyreports no overlap. The log line formats are copied fromGuestBufferMemory.cppandShaderResources.cpponmain, and the display message fromVideoOutDriver.cpp. The memory-budget lines and the display stop were seen on Linux, RTX 3080 Ti, in ASTRO BOT (PPSA21564) and Diablo II: Resurrected (PPSA03912) runs this week.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)AI-assisted; the runs are from my machine(s).