Repository navigation
feat(libc): implement sceLibcBacktraceSelf and GetBufferSize on Windows #8137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
oneandonlydean
merged 8 commits into
boykopovar:main
from
hamb3r:feat/libc-backtrace-windows
Oct 20, 2026
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ba1a85e
feat(libc): add Windows module path helper for backtrace resolution
hamb3r 6fb1b56
feat(libc): implement sceLibcBacktraceSelf and GetBufferSize on Windows
hamb3r 1819d39
test(libc): enable guest_backtrace on Windows and cover path buffer g…
hamb3r 47591f2
docs(debt): update sceLibcBacktrace technical debt entry for Windows
hamb3r 57c8c01
Merge branch 'main' into feat/libc-backtrace-windows
hamb3r 28d0b16
fix(libc): address Windows backtrace review feedback
hamb3r 2693c44
docs(libc): document Windows backtrace stop at PE unwind handlers
hamb3r 50a4d5b
chore(libc): merge main into feat/libc-backtrace-windows
hamb3r File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Windows assertion currently proves only that the first frame resolves to the same executable module. The Linux branch also checks the exact caller symbol (
caller.dli_saddr == self.dli_saddr), so it would catch an off-by-one in the skipped frames that this Windows branch could miss. Sincehandlecame from&CheckBacktrace, could this assert thatreinterpret_cast<std::uintptr_t>(handle) + records.front().offset == reinterpret_cast<std::uintptr_t>(&CheckBacktrace)as well?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 28d0b16: since
records.front().offsetis the call-site return RVA insideCheckBacktracerather than the function entry&CheckBacktrace, the Windows branch now bracketssceLibcBacktraceSelf_nid_postfixwithCurrentIp()(address > before && address < after) and checks thatrecords[1].offsetmatches__builtin_return_address(0).