Repository navigation
feat(libSceNet): implement sceNetShowIfconfigWithMemory - #8234
adriadam10 merged 3 commits into
Conversation
Progress report (b607bfd → ac2591a)📈 System libraries: 48.47% (+0.01%, +2 implemented functions) ✅ 2 implemented
Changed libraries (implemented exports)
|
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
112fbe7 to
f8d51b3
Compare
f8d51b3 to
7f7dfdb
Compare
|
I am reviewing #9506, which adds |
7f7dfdb to
f086ee6
Compare
|
@MarcZX10 Thanks for checking! There is no overlap with #9506:
|
adriadam10
left a comment
There was a problem hiding this comment.
Since this was opened, main changed the sibling diagnostics (04f2d9a, "reject unsupported diagnostic output after initialization"): sceNetShowIfconfig and sceNetShowNetstat now throw once the net library is initialized, because the native output is not implemented, and GuestSceNet.cpp pins that (Failed(sceNetShowIfconfig(), 200)). Returning 0 from sceNetShowIfconfigWithMemory for a valid pool is the plausible-success-where-main-threw case we reject.
core/libs/prx/libSceNet/Export.cpp:2289: keep the pool check (NET_EBADFfor an unknown pool), but for a valid pool throw likesceNetShowIfconfig(throw std::runtime_error(__func__)) instead ofreturn 0.core/libs/tests/GuestSceNet.cpp:280: dropsceNetShowIfconfigWithMemory(pool) == 0; the invalid-pool rows (-1, destroyed pool) stay and still fail without the change. Pin the valid-pool case as a throw if the harness has a way to (see how line 1690 handlessceNetShowIfconfig).docs/dev/debt/libSceNet.md:5: this is no longer a silent stub. Fold it into the existingsceNetShowIfconfig, sceNetShowNetstatline (initialized calls throw).
Rebase onto current main when you push.
f086ee6 to
7799927
Compare
|
@adriadam10 Thanks for the review and clear guidance! Updated as requested:
|
7799927 to
a7efa2e
Compare
a7efa2e to
9ebe598
Compare
9ebe598 to
ac2591a
Compare
|
Re-checked on current main: the pool check ( |
What
Implement
sceNetShowIfconfigWithMemoryincore/libs/prx/libSceNet/Export.cpp:g_pools) underg_mutex, returningNET_EBADFif invalid.std::runtime_error(__func__)for a valid pool once the net library is initialized, aligning with sibling diagnostics (sceNetShowIfconfigandsceNetShowNetstat) per04f2d9a60f.core/libs/tests/GuestSceNet.cppverifying invalid pool failure, destroyed pool failure, and throwing on valid active pool.docs/dev/debt/libSceNet.mdfolded intosceNetShowIfconfig, sceNetShowNetstat.Tested
ninja -C build-linux libSceNet guest_sce_net_testsbuilt cleanly;ctest --test-dir build-linux -V -R guest_sce_netpassed (1/1 tests passed 100%).python tools/check_conventions.py --base origin/main: passed with 0 violations.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)