Repository navigation
revert(ci): run Linux video output tests under Xvfb - #8316
Merged
Merged
Conversation
This reverts the merge of boykopovar#6932 (fce1fef). Its "Install Xvfb" step fails on the self-hosted Linux runner, which has no xvfb-run and no passwordless sudo, so every Linux build stops before configuring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reverts #6932. Its new
Install Xvfbstep fails on the self-hosted Linux runner:xvfb-runis not installed there andsudoneeds a password (sudo: a terminal is required to read the password), so the Linux job stops before it configures. That breaks every Linux build since the merge, includingmain's push build (run 39400385490) and dispatched pull request builds (run 39398806004).#6932 can come back once the runner has
xvfbandxauthinstalled, or the step skips the install when it can't usesudo.Tested
git revert -m 1of the merge commit; the diff is the exact inverse of #6932 (3 files:.github/workflows/build.yml,tools/check_skips.py,tools/tests/test_check_skips.py).Checklist