Repository navigation
docs(agc): say that only a whole-plane storage write retires a depth surface - #8423
Merged
adriadam10 merged 1 commit intoOct 24, 2026
Conversation
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
thuanquang
force-pushed
the
docs/debt-depth-surface-retire-whole-plane
branch
from
October 21, 2026 05:37
96315d6 to
438cfcf
Compare
harisibrar1
approved these changes
Oct 21, 2026
harisibrar1
left a comment
harisibrar1
left a comment
Contributor
There was a problem hiding this comment.
Checked against main:
ShaderResources.cpp:1127-1130callsRetireCoveredDepthSurfacesonly for a written storage view thatDepthSurfaceStorage(:1116) did not serve, so "an unserved storage view" is right.DepthSurface.cpp:2216-2220retires a surface only whenCoveredBy(DepthSurface.cpp:512-531) holds. It holds when the written bytes, or a matching block extent, cover the whole depth or stencil plane, so a partial overlap leaves the surface alive, as the new text says.- The color-target path is the other retire call:
RetireDepthSurfacesatDraw.cpp:2215. "A color target overlaps it" is unchanged and accurate. tools/check_conventions.py --base main --head pr-8423passes.
Reviewed with AI assistance (Claude Code); the checks above were run locally on my machine.
12 tasks done
…surface Co-Authored-By: Claude <noreply@anthropic.com>
thuanquang
force-pushed
the
docs/debt-depth-surface-retire-whole-plane
branch
from
October 22, 2026 04:06
438cfcf to
6e1f2f4
Compare
Collaborator
|
Checked the new clause against main: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
depth surfaceentry indocs/dev/debt/libSceAgcDriver.mdsays a depth surface is retired when "a written storage image it does not serve overlaps it". Since #7050 (a714d1b37), a written storage view retires only depth surfaces whose whole plane it covers:ShaderResources.cpp:1134passes the written bytes and extents toRetireCoveredDepthSurfaces, andDepthSurface.cpp:2489retires a surface only whenCoveredByholds (DepthSurface.cpp:552-573: the written bytes or a matching block extent cover the whole depth or stencil plane), so a partial overlap leaves it alive. The clause now reads "a color target overlaps it, an unserved storage view writes a whole plane, or it is sampled ...".#7154, merged since, edited the next sentence of the same line; this branch is rebased onto it and keeps its text. #9026 (f57bbc9) has since changed the next entry, "Depth planes in guest memory"; this branch is rebased onto
main6ef5a1c and keeps that text too.Tested
Docs only; nothing was built or run. Checked on
main6ef5a1c by readingShaderResources.cpp:1134andDepthSurface.cpp:552-573and:2486-2491; the other retire path,RetireDepthSurfaces(DepthSurface.cpp:2479-2484), is called outside tests only for color targets (Graphics/src/Draw.cpp:2244).CoveredByand both retire functions are unchanged sincea07e985c8; only their line numbers moved.python tools/check_conventions.py --base origin/mainwith this title and body passes.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)🤖 Generated with Claude Code