[harisibrar1]

What

The Conventions workflow checked out pull_request.base.sha, the base recorded when the pull request was opened, and ran that revision's checker. A rule merged after a pull request was opened never ran on it. #7005 passed with the checker of 07e7414, which had no env-reference rule, and merged APS5_NO_WGI without an ENVIRONMENT.md row.

• conventions.yml: check out the current tip of pull_request.base.ref and pass --base HEAD. Check already diffs from git merge-base, so only the pull request's own changes are checked. It still runs only base-branch code and never executes pull request code.
• check_conventions.py: an older branch lacks ENVIRONMENT.md rows added on the base branch after its branch point. Such a row now counts as documented unless the pull request removes it. Without this, feat(input): add native SDL input configuration with ImGui #674 is reported for ANYPS5_INPUT_CONFIG, which main already documents.
• CONTRIBUTING.md: say which checker revision runs.

Effect: an open pull request that breaks a rule merged after it was opened fails on its next push, edit or reopen.

Tested

Windows 11, Python 3.14.

• python -m unittest on every tools/tests/test_check_conventions_*.py and test_env_reference.py: all pass. The new test test_a_row_the_target_added_after_the_branch_point_documents_the_read fails without the check_conventions.py change.
• fix(libSceVideoOut): add APS5_NO_WGI to turn off SDL's Windows.Gaming.Input backend #7005, simulated as CI ran it: checkout 07e7414 with --base 07e741481 passes. Checkout of main at the time of the run with --base HEAD reports APS5_NO_WGI.
• 31 open pull requests spread over the queue, old workflow against new workflow with this branch's checker: 27 identical. feat(input): add native SDL input configuration with ImGui #674 and feat(agc): add opt-in render-state overrides #7275 newly report ANYPS5_EDITOR_SCREENSHOT and APS5_HOT_RELOAD (no rows on main). fix(agc): fault image table entries the device or guest memory cannot hold #6481 and perf(agc): wait at submit only for the preparations of the programs a submission binds #6867 newly get debt-length warnings (no errors).
• python tools/check_conventions.py --base origin/main passes. tools/pr_overlap.py: fix(tools): count assembly exports in the duplicate-export check #8777 and test: organize library tests and label CTest suites #6044 share files, and their hunks were checked by hand with no shared lines.
• The workflow itself was not run on GitHub; it runs on the first pull_request_target event after merge.

Checklist

• Based on current main; no other open PR implements the same functions
• One topic per PR; follow-ups go in a new PR
• No comments in code except technical debt
• Unimplemented paths throw (NotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file
• No notes, investigation .md files or images added to the repository (attach them to this PR)
• New third-party code is a submodule built from source
• Generic behaviour, not specific to one title
• Depends on: none
• Fixes: Fixes ci(conventions): pull requests are checked with the rules of the base they were opened on, so rules merged later never run on them #8891
• Unblocks: none
• GPUs tested: n/a
• AI-assisted: yes

🤖 Generated with Claude Code

[github-actions]

Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.

Pull request	Shared files not compared
PR 6044	CONTRIBUTING.md
PR 9137	tools/check_conventions.py

[harisibrar1]

Checked by hand: #6044 adds a section at CONTRIBUTING.md line 21 (this PR changes line 44), and #8777 changes code() and symbol_nid in tools/check_conventions.py (this PR changes Check.__init__ and env_reference). No shared lines.

[MarcZX10]

I reviewed the base-tip checkout and checker changes, including the merge-base diff behavior and the ENVIRONMENT.md rows inherited from the current target branch. I ran python3 -m unittest discover -s tools/tests -p "test_check_conventions_*.py" (143 passed) and python3 tools/check_conventions.py --base upstream/main (passed) on this head. The PR checks also pass. I found no blocking issue; the workflow integration itself still awaits its first GitHub run after merge.

[adriadam10]

Checked the workflow change (current base tip with --base HEAD, merge-base still scopes the diff, only base code runs), the ENVIRONMENT.md rows inherited from the target (minus rows the PR drops) and the three new tests; the inherited-row test needs the check_conventions.py change. Conventions, intake and labels are green on the head; merged.