You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds 66 pending libSceSaveData exports from the research source list. Each declaration calls NotImplemented_nid_no_patch; signatures and behavior are unverified, and the declarations are for import resolution only. The library technical-debt file records the unknown signatures and behavior.
Tested
Not tested at runtime. python tools/check_conventions.py --base upstream/main passed; git diff --check upstream/main...HEAD passed. Full build and CI have not run.
Checklist
Based on current main; no other open PR implements the same functions
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
I found a gap in my overlap checker: it compared export names literally and did not normalize _nid_postfix / _nid_disambigN aliases, which can resolve to the same NID as a plain name. I updated the checker to compare normalized names and checked this PR against current main and the available open PR diffs; no remaining normalized-name overlap turned up for this PR.
I reviewed this file overlap manually. The normalized export names in this PR do not duplicate exports from #7780 or #8285, but those PRs delete the current libSceSaveData/Export.cpp that this PR adds stubs to. That is a real placement/merge-order conflict. Should these declarations wait until the SaveData implementation direction is settled, then be rebased onto the surviving library export source?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds 66 pending libSceSaveData exports from the research source list. Each declaration calls
NotImplemented_nid_no_patch; signatures and behavior are unverified, and the declarations are for import resolution only. The library technical-debt file records the unknown signatures and behavior.Tested
Not tested at runtime.
python tools/check_conventions.py --base upstream/mainpassed;git diff --check upstream/main...HEADpassed. Full build and CI have not run.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)