Skip to content

feat(libSceSsl): declare PS5 pending exports - #8951

Merged
oneandonlydean merged 3 commits into
boykopovar:mainfrom
xdCloudy:feat/ps5-ssl-exports
Oct 25, 2026
Merged

oneandonlydean merged 3 commits into
boykopovar:mainfrom
xdCloudy:feat/ps5-ssl-exports

Conversation

@xdCloudy

@xdCloudy xdCloudy commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

What

Adds one pending libSceSsl export from the research source list. The declaration calls NotImplemented_nid_no_patch; its signature and behavior are unverified, and it exists for import resolution only. The library technical-debt file records that uncertainty.

Tested

  • python -I tools/check_conventions.py --base upstream/main — passed.
  • git diff --check upstream/main...HEAD — passed.
  • tools/pr_overlap.py scanned locally available open PR heads. It matched this PR against itself because the branch is already open; ignoring that self-match, the only SSL shared-file warning was old-base PR docs: fix Pages workflow link and separate library technical debt #6039. I manually compared its diff: it rewrites the existing sceSslEnableVerifyOption debt paragraph, while this PR adds a separate sceSslSetServerName entry. No other export overlap was reported.
  • Product build jobs are skipped for this declaration-only change; no full build is claimed.

Checklist

  • Based on current main; no other open PR implements sceSslSetServerName
  • One topic per PR; follow-ups go in a new PR
  • No comments in code except technical-debt documentation
  • The unimplemented path throws through NotImplemented_nid_no_patch; the unknown signature is documented
  • No investigation files or images added
  • New third-party code is a submodule built from source (not applicable)
  • Generic behavior, not specific to one title
  • Depends on: docs: fix Pages workflow link and separate library technical debt #6039 (shared SSL debt-file landing order; no export overlap)
  • Fixes: none
  • Unblocks: none
  • GPUs tested: n/a
  • AI-assisted: yes

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Progress report (cf528e7 → 8906049)

📉 System libraries: 48.79% (-0.01%, +1 declared functions)

🆕 1 declared as stubs
Library Name
libSceSsl sceSslSetServerName

Changed libraries (implemented exports)

Library Before After Change
libSceSsl 33/54 (61.11%) 33/55 (60.00%) -1.11 pp

@oneandonlydean

Copy link
Copy Markdown
Collaborator

@xdCloudy thanks. sceSslInit and sceSslTerm are already implemented on main as sceSslInit_nid_postfix (libSceSsl/Export.cpp:616) and sceSslTerm_nid_postfix (:627). A throwing stub under the plain name exports the same NID a second time and can shadow them, and titles call both. Please drop those two (and their debt lines) and keep sceSslSetServerName. The open #8541 also touches sceSslInit/sceSslTerm.

@xdCloudy

Copy link
Copy Markdown
Contributor Author

Removed sceSslInit and sceSslTerm plus their debt references, retaining only sceSslSetServerName. Local conventions and diff checks pass.

@xdCloudy

Copy link
Copy Markdown
Contributor Author

I found a gap in my overlap checker: it compared export names literally and did not normalize _nid_postfix / _nid_disambigN aliases, which can resolve to the same NID as a plain name. I updated the checker to compare normalized names and checked this PR against current main and the available open PR diffs; no remaining normalized-name overlap turned up for this PR.

@xdCloudy

Copy link
Copy Markdown
Contributor Author

I manually compared the shared SSL changes. This PR retains only sceSslSetServerName; #8431's added exports do not include that name, and #6039 is a debt-document restructuring change. No duplicate export was found. The shared source/debt paths may need a rebase or combined hunk if either PR lands first.

@xdCloudy

Copy link
Copy Markdown
Contributor Author

Rebased this branch onto current upstream/main (d34da5d) and resolved the source conflict. The diff remains limited to sceSslSetServerName and its debt note; sceSslInit/sceSslTerm are not added. I manually checked the shared SSL changes in #8541, #9137, and #9173; none adds sceSslSetServerName. #6039 only restructures the debt document. The updated overlap check reports no duplicate export, though it still cannot compare the conflicting branches listed above. Local conventions pass and GitHub conventions, eligibility, labels, and report checks pass; build jobs were skipped for this declaration-only change.

@github-actions github-actions Bot added needs rebase Conflicts with main, rebase needed and removed needs rebase Conflicts with main, rebase needed labels Oct 21, 2026
@xdCloudy
xdCloudy force-pushed the feat/ps5-ssl-exports branch 2 times, most recently from 2a196d7 to 39e9963 Compare October 22, 2026 02:15
@xdCloudy

Copy link
Copy Markdown
Contributor Author

Update: I rebased this branch onto current main (8c26eac) and pushed head 39e9963. Conventions and git diff --check pass, git merge-tree is clean, and the full overlap scan found no other export collision. The only uncomparable SSL file is old-base #6039; I manually verified that it rewrites the existing sceSslEnableVerifyOption debt paragraph while this PR adds a separate sceSslSetServerName entry. The PR body records the shared-file landing order. GitHub now reports CLEAN, although the stale needs rebase label remains; GitHub rejected label removal because repository admin rights are required. Product build jobs are skipped for this declaration-only PR.

@github-actions github-actions Bot removed the needs rebase Conflicts with main, rebase needed label Oct 22, 2026
@xdCloudy
xdCloudy force-pushed the feat/ps5-ssl-exports branch 2 times, most recently from faf69b1 to b2dfc5b Compare October 22, 2026 06:17
@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.

Pull request Shared files not compared
PR 9822 core/libs/prx/libSceSsl/Export.cpp
PR 9826 core/libs/prx/libSceSsl/Export.cpp
PR 10167 core/libs/prx/libSceSsl/Export.cpp

@xdCloudy

Copy link
Copy Markdown
Contributor Author

The bot warning is relevant as a manual-review notice: the current comparison could not inspect the conflicting SSL source in #9822 and #9826, but it does not itself report a duplicate export. I checked the visible diffs: #9822 changes sceSslGetPem, while this PR retains only sceSslSetServerName; they are distinct exports. #8951 was opened on 2026-10-21, before #9822/#9826 on 2026-10-22, so the earlier sceSslSetServerName work should be preserved if a shared-file rebase is needed. I am not claiming the bot comparison itself is clean.

@xdCloudy
xdCloudy force-pushed the feat/ps5-ssl-exports branch 5 times, most recently from 4f3bad6 to bf22cfd Compare October 22, 2026 18:42
@xdCloudy

Copy link
Copy Markdown
Contributor Author

Manual follow-up to the current overlap warning: #8951 adds sceSslSetServerName; #9822 and #9826 change sceSslGetPem. The export names and computed NIDs are distinct, so there is no duplicate declaration. GitHub’s checker still marks those SSL-file comparisons inconclusive because the other branches conflict with main.

@oneandonlydean oneandonlydean self-assigned this Oct 22, 2026
@xdCloudy
xdCloudy force-pushed the feat/ps5-ssl-exports branch from bf22cfd to 743d6b9 Compare October 24, 2026 23:35
@oneandonlydean

Copy link
Copy Markdown
Collaborator

@xdCloudy On 743d6b9 the public_headers test fails under main's new public-header rule: sceSslSetServerName is defined in core/libs/prx/libSceSsl/Export.cpp:1356 but has no declaration in the library's public header. Could you add exactly one matching declaration in include/Ssl.hpp (reachable through libSceSsl.hpp), keeping main's existing signatures as they are? CI's public_headers and public_headers_compile_* tests check it.

@xdCloudy

Copy link
Copy Markdown
Contributor Author

Added the matching public declaration for sceSslSetServerName() in the SSL header, preserving the no-parameter unknown-signature declaration. Local conventions and diff-check pass; this addresses the public_headers complaint. Refreshed hosted checks are pending.

@oneandonlydean
oneandonlydean merged commit 1ee0382 into boykopovar:main Oct 25, 2026
10 checks passed
@xdCloudy

Copy link
Copy Markdown
Contributor Author

I’ve closed my PRs because, based on my personal experience, I’ve decided I will no longer contribute to or update them. This decision is about my experience with the public community and is not directed at the maintainers or active reviewers, whose time and work I appreciate. Thank you for reviewing and discussing my contributions. I wish the project and its maintainers well.

@Rengundom

Copy link
Copy Markdown
Contributor

I’ve closed my PRs because, based on my personal experience, I’ve decided I will no longer contribute to or update them. This decision is about my experience with the public community and is not directed at the maintainers or active reviewers, whose time and work I appreciate. Thank you for reviewing and discussing my contributions. I wish the project and its maintainers well.

image-1.png

@github-actions
github-actions Bot deleted the feat/ps5-ssl-exports branch October 31, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants