Skip to content

test(relinker): run kernel variant imports on Windows - #9000

Open
Queuse wants to merge 3 commits into
boykopovar:mainfrom
Queuse:codex/test-kernel-variant-runtime
Open

Queuse wants to merge 3 commits into
boykopovar:mainfrom
Queuse:codex/test-kernel-variant-runtime

Conversation

@Queuse

@Queuse Queuse commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

What

Add Windows runtime regressions for scoped libkernel_sys/libkernel_web imports: runtime fallback, provider precedence, guest-module isolation and unresolved imports. The implementation from #8867 is now in main; this PR adds only the tests and their CMake registration.

Tested

Windows x86-64, WinLibs MinGW-w64 GCC 15.2.0-r7, Ninja, Release, relinker-only build; rebased on main a6dcea9.

Validation on head 0134370803, including main 1fd6f9bb58: Windows 11 x86-64, WinLibs MinGW-w64 GCC 15.2.0-r7, Ninja, Release, relinker-only. Rebuilt relinker, entry_stub_tests and windows_dependency_diagnostics_tests. windows_kernel_variant_sys, windows_kernel_variant_web, windows_dependency_diagnostics and entry_stub pass (4/4, 14.67 seconds total; each below 30 seconds). Conventions and whitespace checks pass. #6044's proposed test-reorganization order remains awaiting its author's confirmation.

Checklist

  • Based on current main; no other open PR implements the same functions
  • One topic per PR; follow-ups go in a new PR
  • No comments in code except technical debt
  • Unimplemented paths throw (NotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file
  • No notes, investigation .md files or images added to the repository (attach them to this PR)
  • New third-party code is a submodule built from source
  • Generic behaviour, not specific to one title
  • Depends on: none
  • Fixes: none
  • Unblocks: none
  • GPUs tested: n/a
  • AI-assisted: yes

@clairtonmichel

Copy link
Copy Markdown

Tested on AMD Ryzen 7 9800X3D and AMD Radeon RX 7900 XTX (Fedora Linux, Mesa 26.2.5):

  • Built cleanly with zero errors.
  • Ran the complete relinker and kernel variant import test suites (relinker_executables, relinker_conversion, relinker_game_patch, guest kernel modules): 100% passed successfully (15/15 green in 1.15s).
  • Kernel variant imports handling behaves correctly on host. Ready to merge!

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.

Pull request Shared files not compared
PR 5021 core/relinker/CMakeLists.txt
PR 6044 core/relinker/CMakeLists.txt
PR 9408 core/relinker/CMakeLists.txt

@JJenkx

JJenkx commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Independent Windows run, as data only. Machine: Windows 11 Enterprise 10.0.22621, Ryzen 9 5950X, WinLibs GCC 15.2.0 UCRT r7, Release, BUILD_TESTING=ON, Python 3.15. #8654 (c318c70), #8717 (ba9e424) and #9000 (78bfaba) were merged together onto main 830ccd1, without conflicts, and each test was run 3 times. windows_kernel_variant_sys and windows_kernel_variant_web pass 3 of 3.

AI-assisted (Claude Code).

@Queuse

Queuse commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

Refreshed this branch onto main b7d1d47a5 and reran the Windows checks on head a52cc17ded with MSYS2 UCRT64 GCC 16.2.0, Ninja, Release, relinker-only.

All four pass: windows_kernel_variant_sys (15.77 s), windows_kernel_variant_web (16.45 s), windows_dependency_diagnostics (54.72 s) and entry_stub (0.14 s), 87.23 s total. Built the relinker and both native test targets. Conventions and whitespace checks pass. The description records these new results separately from the earlier WinLibs run.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants