Repository navigation
fix(libSceNgs2.native): report one ATRAC9 frame as the parsed decoder delay - #9143
Merged
3 commits merged intoOct 23, 2026
Merged
3 commits merged into
3 commits merged into
Conversation
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
12 tasks done
Contributor
|
Windows run of 4fb7022 merged onto Built |
…-atrac9-parsed-delay
6ee3872
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
sceNgs2ParseWaveformDatareported an ATRAC9 file'snum_delay_samplesfrom the second word of itsfactchunk. prosper's reading oflibSceNgs2.native.sprx, which this debt file already relies on elsewhere, sets that delay for ATRAC9 to one codec frame (delay = unit_samples). It reads thefactdelay word only for type 0x43 (L244). ItsParseAtrac9test passes afactof{900, 0}and expects a delay of 256 ("delay = one frame"). @nikowolf123 pointed this out in #8528.The parser now reports
codec.frameSamples, the same frame length it already writes tonum_audio_unit_samples. The field is only reported to the caller; nothing in the library reads it back. The block skip is unchanged and still comes from the thirdfactword. That is where prosper uses the same one-frame delay, so it is recorded as the remaining difference in a new debt entry, next to the ATRAC9 loop entry.Tested
Ubuntu 26.04.1, kernel 7.0.0-38, GCC 15.2.0, Release, full build with
BUILD_TESTING=ON. Windows was not compiled. No title was run.ngs2_atrac9: the existing ATRAC9 file (fact900, 256, 256) still parses with a delay of 256. Copies with thefactdelay word set to 0, 1, 900 and0xffffffffall report a delay of 256, the same skip of 256 and 900 samples.main, where the delay follows thefactword. All 13ngs2tests pass.tools/check_conventions.py --base origin/mainpasses.tools/pr_overlap.pyfinds no conflicting lines. It could not compare feat(ngs2): decode complete HE-VAG waveform blocks #5797 (HE-VAG decoding) and fix(libSceNgs2): return the custom rack creation errors #8609, which conflict withmain; neither touches the parsed delay.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)