Repository navigation
docs(agc): correct multisampled DCC acceptance in the CB passes debt entry - #9361
Merged
adriadam10 merged 1 commit intoOct 25, 2026
Merged
Conversation
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
thuanquang
force-pushed
the
docs/debt-sweep-agc-cb-passes
branch
from
October 23, 2026 16:42
f9cf441 to
1f295f8
Compare
github-actions
Bot
added
needs rebase
…entry Co-Authored-By: Claude <noreply@anthropic.com>
thuanquang
force-pushed
the
docs/debt-sweep-agc-cb-passes
branch
from
October 24, 2026 12:13
1f295f8 to
befe345
Compare
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
One statement in
docs/dev/debt/libSceAgcDriver.mdno longer matchesmain; it is replaced with whatmaindoes now, and nothing else in the entry changes.DCC over a multisampled color target is unsupportedcheck. Draws (core/libs/prx/libSceAgcDriver/Graphics/src/State.cpp:1465) and CB resolve sources (State.cpp:2049) now decode multisampled DCC on a pipe-aligned, single-layer SW_64KB_R_X target with no color transform or lossy mode (State.cpp:1942-1944). core/libs/prx/libSceAgcDriver/tests/Graphics.cpp:4216-4217 requires such a draw state to decode and to pass DrawRejection. Draws, CB resolves and the FMASK decompress all go through acquire (Draw.cpp:2321, 3152, 3156; MultisampleTarget.cpp:772, called at 1128, 1205 and 1238). Its import reads the DCC keys in every case, including that pass (initialDccClear, MultisampleTarget.cpp:565-605, called at 132 and 336). It accepts only uniform 0x00/0x40/0x80/0xc0 keys or, since PR feat(agc): take RADV's comp-to-single clear of a multisampled DCC target #7600, 0x10 comp-to-single keys, and throws on any other key (MultisampledDccClear, MultisampleTarget.cpp:1034-1049). Now: "the target's FMASK contents are not interpreted. In that pass as elsewhere, multisampled DCC is accepted only as a native multisampled DCC fast clear or comp-to-single clear."Tested
Docs only; nothing was built or run. On origin/main 990f45e I read DecodeColorBuffer and DecodeColorMetadataPass in State.cpp, RunColorMetadataPass and the draw target binding in Draw.cpp, and acquire, the constructor, ApplyFastClear, initialDccClear, checkDccCurrent, MultisampledDccBytes, MultisampledDccClear, createFilled, MaterializeMultisampleTargetClear and ResolveMultisampleTarget in MultisampleTarget.cpp, plus the tests at Graphics.cpp:3979 and 4216-4217, and confirmed that a0c51d5 removed the blanket check and that #7600 (2cca5c0) is on main. Rebased on
main990f45e17d: #7803 added the 'Sample 0 of a multisampled color target' entry right above this one, which stays asmainhas it; only line numbers moved in the cited code. Each statement was found by a read-only sweep of the debt files and confirmed by two independent verifier passes and a final check on currentmain. No open pull request edits these sentences (checked again on990f45e17dagainst the diffs of all 97 open PRs that edit this file).mainb930da950d(headbefe345441) for an adjacent-entry conflict; the edited entry is unchanged onmain. Rechecked onb930da950d(no later change to these files); the line numbers in What are from990f45e17d. Current ones: the drawDecodeColorBufferatState.cpp:1489, the CB resolve source at:2142, the multisampled DCC checks at:2035-:2037, the FMASK decompress at:2157intoDraw.cpp:3363, andacquireatMultisampleTarget.cpp:772, whoseMultisampledDccClear(:1031-:1057) accepts only uniform fast-clear keys or comp-to-single keys with a recorded colour and throws on everything else.python tools/check_conventions.py --base origin/mainwith this title and body passes.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)🤖 Generated with Claude Code