Repository navigation
docs(build): add macOS relinker prerequisites - #9471
Conversation
MarcZX10
left a comment
There was a problem hiding this comment.
Reviewed the one-line relinker-only prerequisite clarification. It names AppleClang’s Xcode Command Line Tools installer and Homebrew packages for CMake/Ninja; the submitted clean-checkout test report includes the full relinker-only build and all 229 registered tests on Apple Silicon. Conventions, intake, and labels pass. No hosted full build was run for this documentation-only change.
MarcZX10
left a comment
There was a problem hiding this comment.
The macOS prerequisite sentence is accurate and the author reports a clean relinker-only build plus all 229 registered tests on Apple Silicon. The #8087 overlap named by the earlier bot is now merged; its added Windows/MSYS2 guidance is separate from this macOS sentence. This branch and test report are based on a6dcea9, while upstream main is now ab347d1. Please rebase/update the branch and refresh the conventions/overlap checks against current main; the hosted docs-path checks pass. I did not run local tests.
Name the commands that provide the compiler, CMake and Ninja on macOS next to the existing mention of AppleClang in the relinker-only section. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
912bbaa to
c5dd9c1
Compare
Dismissing a stale review: the requested changes were addressed after it (new head) and the merge queue blocks on it. Please request changes again if anything is still open.
|
Checked the one-line change against |
What
Name the commands that provide the toolchain for the relinker-only build on macOS:
xcode-select --installfor AppleClang,brew install cmake ninjafor CMake and Ninja. One sentence in the existing macOS mention of the Relinker only section; Linux and Windows already name their packages and toolchain there.Tested
macOS 27.0.1 on Apple Silicon (arm64), AppleClang 21.0.0, CMake 4.4.4 and Ninja 1.13.2 from Homebrew 7.0.7, Python 3.14.6 from Homebrew.
brew install cmake ninjawas run on this machine and provided both tools.xcode-select --installwas not run here because the command-line tools were already installed at/Library/Developer/CommandLineTools.Relinker-only build from a clean checkout of
main(a6dcea9), with the commands of the section:Configure found Python 3.14; build 237 steps in 19 s;
100% tests passed out of 229;ctest -Nlistsinput_magic(#199).python3 tools/check_conventions.pypassed andpython3 tools/pr_overlap.py --branch docs/macos-relinker-prerequisitesreports no overlap.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)🤖 Generated with Claude Code