Repository navigation
Conversation
|
I checked #9931’s open TCP_NODELAY readback change alongside this PR. The behavior is distinct, but both patch |
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
|
One additional overlap surfaced: #9932 adds |
|
@MarcZX10 I checked the two heads together ( Both also merge cleanly with main |
|
I completed a diff/code pass on the The branch is 2 commits ahead/48 behind current |
MarcZX10
left a comment
There was a problem hiding this comment.
Reviewed exact head c079a98a411093257bbd88f3fd8f28a836d438ec. Effective/default protocol selection and accepted-socket inheritance are covered, output-size/error behavior is tested, and unsupported raw sockets remain explicit in debt. Current-main diff-check and conventions pass; the branch merges cleanly and no intervening main commit touched the changed paths. The author’s combined Windows + WSL2 integration run reports all 8 focused network tests passing with #9931/#9932 and related prerequisite changes. I did not rerun the C++ tests locally. The documented merge prerequisite #9543 (including #9525), and #8686’s agreed later order, remain; preserve both this and #9931’s getter/test/debt changes through final rebase.
What
Read
SO_PROTOCOLfor IPv4/IPv6 stream and datagram sockets, including default protocol selection and accepted-socket inheritance, following FreeBSD 11.4 sogetopt. Raw protocol mapping remains unimplemented and throws; console measurements remain in library debt.Tested
Windows 11 x86-64, WinLibs MinGW-w64 GCC 15.2.0-r7, Ninja, Release. Head
2103fdf846includes main2fade7ef4e.guest_net_protocol: 1/1 pass, with no skips.Integration order remains #9523 → #9542 → #9515 → #9578 and #9525 → #9543 → #9930 → #8686; #9931 follows #9542. #9930/#9931 may land independently after their prerequisites, before the agreed #9932/#9948 updates. Preserve every option path, short-buffer rule, test and debt entry.
#6044 was closed without merging its test relocation, so that former coordination item is retired. The existing #5836 order proposal remains unconfirmed; its peer-transport and broadcast-alias changes must retain current buffer validation and option state when integrated. No author agreement is assumed.
Earlier combined Windows/WSL2 network results remain tied to tree c9c1293; they are separate from this head's fresh Windows run.
Fresh overlap snapshot
30be9b428b: existing getter/debt intersections remain covered by the ordering above. 7 shared-file comparisons are incomplete because those branches conflict with the base: #5836, #7201, #9727, #9733, #9948, #10502, #10706. Manual inspection identifies export-header refactoring (#10706), diagnostic display (#10502), argument validation (#9727), send/platform paths (#9733/#7201), socket records (#9948), and the already pending peer/broadcast changes (#5836). No duplicate option branch was found in the inspected shared hunks. Retain the private socket fields, canonical declarations, test registrations and debt entries when integrating. These source checks do not establish author agreement or a combined runtime pass.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)