Skip to content

Fix the version_id changes after moving the weight files; fix dependency issues with temporal models#1249

Open
YingtianDt wants to merge 139 commits into
brain-score:masterfrom
YingtianDt:master
Open

Fix the version_id changes after moving the weight files; fix dependency issues with temporal models#1249
YingtianDt wants to merge 139 commits into
brain-score:masterfrom
YingtianDt:master

Conversation

@YingtianDt

@YingtianDt YingtianDt commented Sep 17, 2024

Copy link
Copy Markdown
Contributor

No description provided.

Yingtian Tang and others added 30 commits February 25, 2024 09:23
feature: support temporal models for neural alignment by chaning Temp…
d97d452 
…oralIgnore to Temporal Aligned
@YingtianDt
Merge branch 'brain-score:master' into master
2a32f46
@YingtianDt
add example temporal submission
c372d12
@YingtianDt
Merge branch 'master' of https://github.com/YingtianDt/brain-score
40d2d2b 
Update to the newest origin main.
@YingtianDt
Merge branch 'brain-score:master' into master
c0827b3
@YingtianDt
complete new framework
92cede9
@YingtianDt
Merge branch 'master' of https://github.com/YingtianDt/brain-score
e74015d 
merge new updates from origin main
@YingtianDt
new module: temporal model helpers
088b9af
@YingtianDt
change the arch of temporal; add tutorials
c5b9097
@YingtianDt
improve: better naming
8f301a3
@YingtianDt
update: wrapper tutorial on brain model
3c3e475
@YingtianDt
add feature: inferencer identifier tracked by extractor for result ca…
34fbc08 
…ching
@YingtianDt
fix: video fps sampling; need more tests!
f6c2fe4
@YingtianDt
fix bugs: video sampling based on fps was wrong.
7e948ed
@YingtianDt
Merge branch 'brain-score:master' into master
3998027
@YingtianDt
add mmaction2 models; add more features to the inferencers
17ecc5d
@YingtianDt
Merge branch 'master' of https://github.com/YingtianDt/brain-score
5fac41c 
merge updates
@YingtianDt
Merge branch 'brain-score:master' into master
20941fe
@YingtianDt
PR: temporal model helpers
89bf58c
@YingtianDt
PR fix: not including gitmodules for now
1433635
@YingtianDt @mschrimpf
Update brainscore_vision/model_helpers/brain_transformation/temporal.py
b678e95 
Co-authored-by: Martin Schrimpf <mschrimpf@users.noreply.github.com>
@YingtianDt @mschrimpf
Update brainscore_vision/model_helpers/brain_transformation/temporal.py
905c964 
Co-authored-by: Martin Schrimpf <mschrimpf@users.noreply.github.com>
@YingtianDt @mschrimpf
Update brainscore_vision/model_helpers/brain_transformation/temporal.py
e1e77ca 
Co-authored-by: Martin Schrimpf <mschrimpf@users.noreply.github.com>
@YingtianDt @mschrimpf
Update brainscore_vision/models/temporal_models/test.py
817b448 
Co-authored-by: Martin Schrimpf <mschrimpf@users.noreply.github.com>
@YingtianDt
add mae_st; add ding2012
ad8cf5a
@YingtianDt
Merge branch 'master' of https://github.com/YingtianDt/brain-score
749c371 
merge
@YingtianDt
try new arch
95e413e
@YingtianDt
merge
d020363
@YingtianDt
init ding2012
d6960fc
@YingtianDt
add tests for temporal model helpers; add block inferencer
227e801
@mike-ferguson

mike-ferguson commented Sep 17, 2024

Copy link
Copy Markdown
Member

@YingtianDt thanks! Our PR testing is right in the middle of being ported to AWS, so thanks for hanging in there while we sort all of the bugs out.

@kvfairchild kvfairchild added the OOM When unit tests run out of memory label Oct 1, 2024
@YingtianDt

YingtianDt commented Oct 2, 2024

Copy link
Copy Markdown
Contributor Author

I believe this PR is ready to be merged. @mschrimpf

@KartikP

KartikP commented Oct 2, 2024

Copy link
Copy Markdown
Collaborator

@YingtianDt Your PR has a couple of issues. Some of them arise from a saturation of disk space for the tests (on AWS execution tests), which we will increase for you. But it appears temporal_model_mmaction2 is failing your plugin-specific tests (on the legacy unit test plugins).

@mschrimpf All generic tests have failed. Is this because this is just a "different class" of models. Should anything be changed in terms of how unittest_plugins is run?

@mschrimpf

mschrimpf commented Oct 9, 2024

Copy link
Copy Markdown
Member

All generic tests have failed. Is this because this is just a "different class" of models. Should anything be changed in terms of how unittest_plugins is run?

The models should still pass on the generic tests. @YingtianDt any ideas why these seem to fail?

@mschrimpf

mschrimpf commented Jul 25, 2025

Copy link
Copy Markdown
Member

once unit tests pass this looks good to merge

@YingtianDt YingtianDt closed this Nov 13, 2025
@YingtianDt YingtianDt reopened this Nov 13, 2025
@KartikP KartikP removed the OOM When unit tests run out of memory label Nov 13, 2025
@YingtianDt YingtianDt closed this Nov 13, 2025
@YingtianDt YingtianDt reopened this Nov 13, 2025
@KartikP KartikP closed this Mar 27, 2026
@KartikP KartikP reopened this Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mschrimpf mschrimpf mschrimpf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@YingtianDt @mike-ferguson @KartikP @mschrimpf @kvfairchild @deirdre-k