Link statically - #11
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Nix flake to produce statically linked Linux builds (via musl) and to validate that the resulting binaries do not depend on dynamic loaders/libraries, while keeping the existing macOS “no Nix store dylib deps” safeguard.
Changes:
- Adds per-system Rust target selection (musl targets for Linux) and configures the Rust toolchain to include those targets.
- Switches Linux package builds to cross-configure nixpkgs for musl and sets Cargo target/rustflags accordingly.
- Adds Linux post-fixup checks (via
readelf) to fail the build if the resulting binary is dynamically linked.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dmeijboom
force-pushed
the
feat/link-statically
branch
2 times, most recently
from
August 17, 2026 13:41
1c5d2ab to
ce369bf
Compare
dmeijboom
force-pushed
the
feat/link-statically
branch
from
August 17, 2026 14:34
ce369bf to
5627fe0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.