Skip to content

fix: stop shipping a second copy of the toolchain in every Railpack image #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeroenrinzema wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: stop shipping a second copy of the toolchain in every Railpack image #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9eb7253
fix: stop shipping a second copy of the toolchain in every Railpack i…
jeroenrinzema Aug 8, 2026
811f0df
style: stop commenting code that explains itself
jeroenrinzema Aug 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/auth.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,10 +133,6 @@ struct AuthorizeAnnouncement<'a> {
expires_in_seconds: u64,
}

/// Writes the authorization URL to stdout before waiting for the callback.
///
/// The authorization URL redirects to a loopback address, so it only completes
/// in a browser running on the same machine as the CLI.
fn write_authorization_notice(authorize_url: &str, options: LoginOptions) -> Result<()> {
let notice = authorization_notice(authorize_url, options)?;
let stdout = io::stdout();
Expand Down
4 changes: 3 additions & 1 deletion src/image/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,14 @@ const RAILPACK_FRONTEND: &str = "ghcr.io/railwayapp/railpack-frontend:v0.35.0";
const PROCESS_TIMEOUT: Duration = Duration::from_secs(60 * 60);
const PROCESS_OUTPUT_DRAIN_TIMEOUT: Duration = Duration::from_secs(1);
const NETWORK_TIMEOUT: Duration = Duration::from_secs(30 * 60);
// Never chown /mise here: it arrives from an earlier layer, so rewriting its
// ownership copies the entire toolchain into this one (194 MB for a Node app).
const NON_ROOT_DOCKERFILE: &str = r#"FROM base
RUN groupadd --gid 1000 railpack \
&& useradd --uid 1000 --gid 1000 --home-dir /home/railpack --create-home --shell /bin/false railpack \
&& if [ -d /root ]; then cp -a /root/. /home/railpack/; fi \
&& chown -R 1000:1000 /home/railpack \
&& if [ -d /mise ]; then chown -R 1000:1000 /mise; fi
&& if [ -d /mise ]; then install -d -o 1000 -g 1000 /mise/cache /mise/migrations; fi
ENV HOME=/home/railpack
USER 1000:1000
"#;
Expand Down