Repository navigation
fix(code-editor): POLISH-APP-4 — drain design drift - #413
Merged
Merged
Conversation
Drift: 14 literal colors -> 0. All were dead var(--x, rgba(...)) fallbacks on guaranteed tokens: the grey hover/accent-soft stand-ins, the popover/xl shadows, and the sheet dimmer. No syntax-theme literals live in CSS. Rubric walk: chrome already fully on shared primitives (object menu, panel toggles, EmptyState, accent-soft selection). Evidence: harness session 313 (file list + editor, both app themes). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POLISH-APP-4 — Code editor (fourth rung of the per-app design-polish program)
Drift drain: 14 literal colors → 0 in
apps/code-editor/src/styles.css. All 14 were deadvar(--x, rgba(…))fallbacks on guaranteed tokens: neutral-grey stand-ins for--hover/--accent-softfills (list rows, find matches, completion items), the--shadow-popover/--shadow-xlshadows, and the--color-dimmersheet backdrop. The feared syntax-theme literals turned out not to live in CSS at all.Rubric walk: chrome verified compliant — shared object menu, panel toggles,
<EmptyState>(references panel + list), accent-soft selection fills throughout. No fixes needed.Evidence: harness session
313-polish-code-editor-both-themes— file list with selected row + editor + references panel in both app themes, all token-driven.Verify:
bun run verifygreen (exit 0); code-editor suite 52 files / 555 tests green; per-apptscclean.Branch-note: the drift baseline here still carries the browser entry (17) because #412 is unmerged; both PRs delete disjoint baseline entries and merge cleanly in either order.
🤖 Generated with Claude Code