feat: add span customizers (SDK-316) - #251
Merged
Merged
Conversation
Andrew Kent (realark)
force-pushed
the
ark/SDK-316-span-customizers
branch
from
September 24, 2026 14:32
e75ce27 to
d572871
Compare
Andrew Kent (realark)
marked this pull request as ready for review
September 24, 2026 14:35
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d572871187
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
Abhijeet Prasad (AbhiPrasad)
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI Generated Description
Summary
Implements SDK-316 using the span customizer specification and the Java exporter reference.
config.SpanCustomizer{OnSpanExport: ...}andbraintrust.WithSpanCustomizers(...), plus direct trace configuration support.sdktrace.ReadOnlySpanexport snapshots for immediate-key, lazy-auth, and injected exporters.examples/internal/span-customizersexample.Verification
GODEBUG=panicnil=1failure handling passed.make test buildpassed, including root, all releasable nested modules, btx, and Orchestrion injection tests (with the pinned Orchestrion v1.12.1 binary).The new wire-level tests directly import existing OTLP/protobuf dependencies;
go mod tidypromotes those two dependencies from indirect to direct without version changes.Contract boundaries
Hooks run after existing attachment processing; already uploaded attachments cannot be retracted. Separately enabled trace-console logging is not customized. Transport retries reuse transformed spans; an explicit exporter resubmission reruns hooks. Callback closure state must be concurrency-safe.