Respect service-specific endpoint env variables#1046
Draft
chreekat wants to merge 1 commit into
Draft
Conversation
e8b26be to
06c00ac
Compare
Contributor
Author
|
Alas, this patch doesn't work the way it should. I'm just using awscli for comparison. With awscli, if I just set AWS_ENDPOINT_URL, it isn't used as an absolute override for services. The service-specific endpoint prefixes are still applied. This patch doesn't do that yet. It should. |
Contributor
Author
|
core's Amazonka.Endpoint.defaultEndpoint has a lot of special-casing. Somebody with more knowledge would need to figure out how AWS_ENDPOINT_URL interacts with all of that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #1013. This version is enabled by default, and has fixed one bug in the original patch.
TODO:
customEndpointsfrom the moduleOpening as a draft so I can get feedback on #1.