enhance request handling with NFData instances#1050
Conversation
|
@endgame could you please take a look and let me know if this is moving in right direction ? |
|
I'm not convinced that it's right but I'm also not convinced that it's wrong. For a subtle laziness issue like this we need to replicate it first, and then prove that the PR fixes it. This probably means standing up some temporary lambda infrastructure to make requests against. I would probably also consider the |
Here is the gist of the changes: (Generated with AI)
The handwritten S3 encryption wrappers were also audited:
The expanded regression coverage now includes discarded signed and unsigned sends, request hooks, response-hook ordering, retries, pagination, waiter retries, parse failures, streaming body readability, and encrypted request wrappers. Validation completed:
This keeps the public streaming interface intact while ensuring ordinary parsed responses are fully evaluated at the request boundary, even when callers discard the returned value. @endgame I would appreciate another look at the final approach. |
@endgame this should close #523. Do let me know if you think this is not a correct way of solving the issue