Skip to content

fix(arm): Allow min tls 1.3 for azure storage min tls #7637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wilsonge wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(arm): Allow min tls 1.3 for azure storage min tls #7637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27fbdbd
Allow TLS 1.3 for storage accounts with ARM
wilsonge Aug 3, 2026
af5b3b8
Add test
wilsonge Aug 3, 2026
df96eab
Bump expected
wilsonge Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions checkov/arm/checks/resource/StorageAccountMinimumTlsVersion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
class StorageAccountMinimumTlsVersion(BaseResourceCheck):
def __init__(self) -> None:
"""
Looks for min_tls_version configuration at azurerm_storage_account to be set to TLS1_2
Looks for min_tls_version configuration at azurerm_storage_account to be set to TLS1_2 or TLS1_3
https://www.terraform.io/docs/providers/azurerm/r/storage_account.html#min_tls_version
:param conf: azurerm_storage_account configuration
:return: <CheckResult>
Expand All @@ -24,7 +24,7 @@ def __init__(self) -> None:
def scan_resource_conf(self, conf: dict[str, Any]) -> CheckResult:
if "properties" in conf and \
"minimumTlsVersion" in conf["properties"] and \
conf["properties"]["minimumTlsVersion"] in ['TLS1_2']:
conf["properties"]["minimumTlsVersion"] in ['TLS1_2', 'TLS1_3']:
return CheckResult.PASSED
return CheckResult.FAILED

Expand Down
55 changes: 55 additions & 0 deletions ...ample_StorageAccountMinimumTlsVersion/exampleStorageAccountMinimumTlsVersion-passed2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
{
"$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentTemplate.json#",
"contentVersion": "1.0.0.0",
"parameters": {
"storageAccountType": {
"type": "string",
"defaultValue": "Standard_LRS",
"allowedValues": [
"Standard_LRS",
"Standard_GRS",
"Standard_ZRS",
"Premium_LRS"
],
"metadata": {
"description": "Storage Account type"
}
},
"location": {
"type": "string",
"defaultValue": "[resourceGroup().location]",
"metadata": {
"description": "Location for all resources."
}
}
},
"variables": {
"storageAccountName": "[concat('store', uniquestring(resourceGroup().id))]"
},
"resources": [
{
"type": "Microsoft.Storage/storageAccounts",
"apiVersion": "2019-04-01",
"name": "[variables('storageAccountName')]",
"location": "[parameters('location')]",
"sku": {
"name": "[parameters('storageAccountType')]"
},
"kind": "StorageV2",
"properties": {
"minimumTlsVersion": "TLS1_3",
"supportsHttpsTrafficOnly": true,
"networkAcls": {
"defaultAction": "Deny",
"bypass": "AzureServices"
}
}
}
],
"outputs": {
"storageAccountName": {
"type": "string",
"value": "[variables('storageAccountName')]"
}
}
}
2 changes: 1 addition & 1 deletion tests/arm/checks/resource/test_StorageAccountMinimumTlsVersion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def test_summary(self):
test_files_dir = current_dir + "/example_StorageAccountMinimumTlsVersion"
report = runner.run(root_folder=test_files_dir, runner_filter=RunnerFilter(checks=[check.id]))
summary = report.get_summary()
self.assertEqual(summary['passed'], 1)
self.assertEqual(summary['passed'], 2)
self.assertEqual(summary['failed'], 3)
self.assertEqual(summary['skipped'], 0)
self.assertEqual(summary['parsing_errors'], 0)
Expand Down