Skip to content

fix(kubernetes): prevent CKV2_K8S_5 per-rule secrets bypass in ClusterRole #7640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SandwichProtector wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(kubernetes): prevent CKV2_K8S_5 per-rule secrets bypass in ClusterRole #7640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 5 additions & 22 deletions checkov/kubernetes/checks/graph_checks/ReadAllSecrets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,28 +39,11 @@ definition:
- Role
- or:
- cond_type: attribute
attribute: rules.resources
operator: not_intersects
value:
- 'secrets'
- '*'
resource_types:
- ClusterRole
- Role
- cond_type: attribute
attribute: rules.verbs
operator: not_intersects
value:
- 'get'
- 'watch'
- 'list'
- '*'
resource_types:
- ClusterRole
- Role
- cond_type: attribute
attribute: rules.resourceNames
operator: exists
attribute: >-
$.rules[?((@.resources[*] == 'secrets' | @.resources[*] == '*') &
(@.verbs[*] == 'get' | @.verbs[*] == 'watch' | @.verbs[*] == 'list' |
@.verbs[*] == '*') & !@.resourceNames)]
operator: jsonpath_not_exists
resource_types:
- ClusterRole
- Role
33 changes: 33 additions & 0 deletions ...bernetes/graph/checks/resources/ReadAllSecrets/Failing/MixedResourceNamesClusterRole.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: mixed-secret-reader
rules:
- apiGroups:
- ""
resources:
- "secrets"
verbs:
- "get"
- "watch"
- "list"
- apiGroups:
- ""
resources:
- "secrets"
resourceNames:
- "pull-secret"
verbs:
- "get"
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
name: mixed-secrets-global
subjects:
- kind: ServiceAccount
name: sa1
roleRef:
kind: ClusterRole
name: mixed-secret-reader
apiGroup: rbac.authorization.k8s.io
3 changes: 2 additions & 1 deletion tests/kubernetes/graph/checks/resources/ReadAllSecrets/expected.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@ pass:
- "ClusterRoleBinding.default.read-pods-global"
- "RoleBinding.my-namespace.my-role-binding"
fail:
- "ClusterRoleBinding.default.read-secrets-global"
- "ClusterRoleBinding.default.read-secrets-global"
- "ClusterRoleBinding.default.mixed-secrets-global"