make bcore-mutation suitable for secp256k1 🥷#43
Merged
Conversation
Add an optional --min-score flag to the analyze command: when the final mutation score (killed / total, aggregated across all analyzed folders) falls below it, analyze returns an error and exits non-zero, failing CI. When unset, the score is not enforced. Backed by a dedicated ScoreBelowThreshold error variant; the value is validated to be in [0,1]. Also hoist the one-time clean build out of analyze_folder into run_analysis so it runs once per invocation instead of once per mutant folder. Per-mutant incremental rebuilds still happen inside each test command. Guarded so it is skipped when --command is given or there are no folders to analyze. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Move the hardcoded non-source file skip list out of run_mutation and into Project::should_skip_file, backed by per-project substring and suffix tables. Bitcoin Core behavior is unchanged; secp256k1 now skips its own docs, tooling, examples, benchmarks and test/bench impl files. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Field normalization functions (secp256k1_fe_normalize and its _weak, _var, _to_zero, _to_zero_var variants) only canonicalize the internal limb representation without changing the represented value. Deleting a call to them almost always yields an equivalent, non-useful mutant, so add the secp256k1_fe_normalize substring to the skip list. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.