Add DialTimeout API#3
Merged
Merged
Conversation
This was referenced Dec 14, 2016
|
Why merge this here and not upstream? |
Member
Author
|
We can try. samuel#3 But we can get this in now if upstream doesn't merge. |
Member
|
Since upstream is unresponsive i'm ok with adding this to our fork. That said I think it can be simplified by using the zero value for a timeout, for the non-timeout version. See https://golang.org/src/net/dial.go#L259 for the two Dial calls. Both create a dialer and call it's Dial method, but the non-timeout version leaves the timeout as the zero value. |
jrick
approved these changes
Jan 3, 2017
Member
|
@davecgh might need your review too since I don't have write access to this repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.