Repository navigation
ci: resolve release dependency checks against in-repo packages - #1074
Merged
Merged
Conversation
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Protocol / Release dependency checkandWinds / Release dependency checkresolvemix_protocolandmix_windsagainst the published pub.dev Mix, then analyze and test them. This blocks any PR that changespackages/mixtogether with the dependents that need the change. For example, #1072 addsBlurModifierMix.tileMode:mix_protocolcodec update, the main test job fails, becausemix_protocolchecks each styler's field count against a fixed list.tileModedoes not exist in the published mix 2.2.0.No version of that PR can pass both jobs. After such a change merges,
mainstays red on this job until Mix is released.Change
In
.github/workflows/test.yml, both release-dependency jobs now:pubspec_overrides.yamlthat pointsmix,mix_annotations, and (for winds)mix_protocolat the repository. Winds also gets one for its example. They still run a plainflutter pub getwithout Melos, then analyze and test the package on its own.flutter analyze --no-fatal-infos, matchingmelos run analyze:dart. Deprecations in unreleased Mix (for example feat(mix): deprecate styler convenience shorthands #1063) show up as infos in dependents.dart pub publish --dry-run, so the dry run still resolves the declared constraints (mix: ^2.2.0) against pub.dev.workflow_dispatch) withpublished_deps: true. That run checks against pub.dev only, which is the old behavior.Where the published-dependency guarantee is enforced now
publish.ymlcallsbtwld/dart-actions. That workflow runs a plainflutter pub get(overrides are gitignored and never checked in),flutter test, anddart pub publish --dry-run, all before publishing. A dependent that needs unreleased Mix fails there and is not published.published_depsenabled to get the old pub.dev-only check.Examples / Published Mixis left as it is. Keeping the showcase working with published Mix is deliberate there.Verification
actionlint .github/workflows/test.ymlpasses.mix_protocol: analysis passes (9 infos), 405 tests pass.mix_winds: analysis passes with no issues, 824 tests pass.mix,mix_annotations, andmix_protocolfrom the repo paths.dart pub publish --dry-runonmix_protocolwithout overrides: 0 warnings.