Recommend a no-cache rule for GitHub embeds on BYO domains - #845
Conversation
- verify pipeline reads Cache-Control from the public-URL probe and emits a recommended-only embed-cache check when badge-style no-cache headers are missing (only when the domain actually answered) - settings form treats embed-cache as optional-but-recommended: never blocks saving; the tip surfaces on the lane card after a successful save - /docs/byo-bucket gains setup step 4 (Transform Rule recipe + caching trade-off) and the GitHub-embeds bullet now points at it; the in-form setup help mirrors the step
|
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (2)
🚫 Excluded labels (none allowed) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Direction for #592: instead of building a platform-proxied embed twin for BYO hosts, recommend customers put the same badge-style cache rule
embed.uploads.shuses onto their own custom domain.Cache-Control, and a new recommended-onlyembed-cachecheck warns when it lacksno-store/no-cache— with the exact Transform Rule value in the hint. Emitted only when the domain actually answered, so it never stacks noise on an unreachable-domain failure, and it never gatesok.embed-cacheis the one check that doesn't block saving. If it's the only warning, the save proceeds and the tip renders on the lane card afterward; alongside real failures it renders in body color, not error red./docs/byo-bucketgains an "Optional but recommended" setup step with the Transform Rule recipe and the edge-caching trade-off (plus the second-domain escape hatch for high-traffic buckets); the "What's different" GitHub-embeds bullet now says embeds work with the rule rather than being unsupported. The in-form setup help mirrors the step.Testing
Closes #592.