Skip to content

Recommend a no-cache rule for GitHub embeds on BYO domains - #845

Merged
Zach Dunn (zachdunn) merged 1 commit into
mainfrom
claude/byo-embed-cache-rule
Aug 25, 2026
Merged

Recommend a no-cache rule for GitHub embeds on BYO domains#845
Zach Dunn (zachdunn) merged 1 commit into
mainfrom
claude/byo-embed-cache-rule

Conversation

@zachdunn

Copy link
Copy Markdown
Member

Summary

Direction for #592: instead of building a platform-proxied embed twin for BYO hosts, recommend customers put the same badge-style cache rule embed.uploads.sh uses onto their own custom domain.

  • Verify pipeline: the public-URL probe now records the response's Cache-Control, and a new recommended-only embed-cache check warns when it lacks no-store/no-cache — with the exact Transform Rule value in the hint. Emitted only when the domain actually answered, so it never stacks noise on an unreachable-domain failure, and it never gates ok.
  • Settings form: embed-cache is the one check that doesn't block saving. If it's the only warning, the save proceeds and the tip renders on the lane card afterward; alongside real failures it renders in body color, not error red.
  • Docs: /docs/byo-bucket gains an "Optional but recommended" setup step with the Transform Rule recipe and the edge-caching trade-off (plus the second-domain escape hatch for high-traffic buckets); the "What's different" GitHub-embeds bullet now says embeds work with the rule rather than being unsupported. The in-form setup help mirrors the step.

Testing

  • New verify tests: warns on cacheable headers, passes on no-store/no-cache, omitted when the domain is unreachable
  • Full suite passing (5165), typecheck clean

Closes #592.

- verify pipeline reads Cache-Control from the public-URL probe and emits a
  recommended-only embed-cache check when badge-style no-cache headers are
  missing (only when the domain actually answered)
- settings form treats embed-cache as optional-but-recommended: never blocks
  saving; the tip surfaces on the lane card after a successful save
- /docs/byo-bucket gains setup step 4 (Transform Rule recipe + caching
  trade-off) and the GitHub-embeds bullet now points at it; the in-form
  setup help mirrors the step
@changeset-bot

changeset-bot Bot commented Aug 25, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0c2f9c9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (2)
  • coderabbit:review
  • review
🚫 Excluded labels (none allowed) (1)
  • wip

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d274f5d2-3c7a-4bc8-a39c-fa5edb0a1b2f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zachdunn
Zach Dunn (zachdunn) merged commit fa350ad into main Aug 25, 2026
5 checks passed
@zachdunn
Zach Dunn (zachdunn) deleted the claude/byo-embed-cache-rule branch August 25, 2026 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BYO buckets: embed-friendly twin host for customer domains

1 participant