feat(cache): parse save_scopes from cache.yml

[buildkate]

Description

Adds save_scopes support to cache.yml. On save, the enabled scopes (branch, build, pipeline) are resolved from env vars sent to the cache registry as a scopes object on the store request. Config-driven only; no CLI flag.

Context

Resolves A-1420

Changes

• config (internal/cache/configuration): add SaveScopes map[string]bool to Cache
• resolver: ResolveSaveScopes resolves enabled scopes to env vars, skips disabled ones
• api (api/cache.go): add Scopes to CacheEntryCreateReq
• save (internal/cache/save.go): resolve scopes in Save() and populate the create request;

Testing

• Tests have run locally (with go test ./...). Buildkite employees may check this if the pipeline has run automatically.
• Code is formatted (with go tool gofumpt -extra -w .)

Affiliation (optional, external contributors)

Buildkite

Disclosures / Credits

Claude

[buildsworth-bk-app]

I didn't find any code findings to raise. I'm leaving this as a comment rather than an approval because this changes cache save scoping / the agent cache API wire protocol, which I read as above the AI approval ceiling.

Want to dig deeper? The full session log is attached to this Buildkite build. Download the session file and open a new pi session with it:

Download the buildsworth logs from build 2648, then answer my questions about the findings.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4b5b3e8fab

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[buildsworth-bk-app]

I found one scope-resolution question around CLI/env overrides. I'm leaving this as a comment rather than an approval because this changes the cache save API wire protocol, which is above the AI approval ceiling.

Want to dig deeper? The full session log is attached to this Buildkite build. Download the session file and open a new pi session with it:

Download the buildsworth logs from build 2766, then answer my questions about the findings.

Previous concerns have been addressed.

[buildsworth-bk-app]

The previous scope-resolution concern is fixed: save_scopes now sends the boolean scope selection instead of client-resolved branch/pipeline values. I didn't find new issues; I'm leaving this as a comment rather than an approval because this changes the cache save API wire protocol, which is above the AI approval ceiling.

Want to dig deeper?

The full session log is attached to this Buildkite build. Download the session file and open a new pi session with it:

Download the buildsworth logs from build 3165, then answer my questions about the findings.

[buildsworth-bk-app]

I didn't find any code findings on this pass. I'm leaving this as a comment rather than an approval because this changes the cache save API wire protocol, which is above the AI approval ceiling.

Want to dig deeper?

The full session log is attached to this Buildkite build. Download the session file and open a new pi session with it:

Download the buildsworth logs from build 3173, then answer my questions about the findings.