Skip to content

TypeError in stop signal handler #3345 #3346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mkf-sysangels wants to merge 1 commit into
base: dev
Choose a base branch
from
+5 −1
Open

TypeError in stop signal handler #3345 #3346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/ui/temp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,13 @@ def stop(status):


def handle_stop(signum, frame):
# stop() accepts exactly one positional argument (exit status).
# Calling stop(0, False) raises TypeError at shutdown:
# TypeError: stop() takes 1 positional argument but 2 were given
# The second argument was spurious and has been removed.
LOGGER.info("Caught stop operation")
Comment on lines 37 to 42
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion | 🟠 Major

Replace inline rationale block with a function docstring

On Line 37-Line 42, prefer a concise docstring on handle_stop rather than multi-line inline comments; this keeps the function self-documented and aligned with project standards.

Proposed refactor 
 def handle_stop(signum, frame):
-    # stop() accepts exactly one positional argument (exit status).
-    # Calling stop(0, False) raises TypeError at shutdown:
-    #   TypeError: stop() takes 1 positional argument but 2 were given
-    # The second argument was spurious and has been removed.
+    """Handle SIGINT/SIGTERM and terminate the temporary UI process cleanly."""
     LOGGER.info("Caught stop operation")
     LOGGER.info("Stopping web ui ...")
     stop(0)

As per coding guidelines, "**/*.py: Use snake_case for functions and variables, PascalCase for classes, and provide concise, accurate docstrings for public classes, functions, and methods."

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
def handle_stop(signum, frame):
# stop() accepts exactly one positional argument (exit status).
# Calling stop(0, False) raises TypeError at shutdown:
# TypeError: stop() takes 1 positional argument but 2 were given
# The second argument was spurious and has been removed.
LOGGER.info("Caught stop operation")
def handle_stop(signum, frame):
"""Handle SIGINT/SIGTERM and terminate the temporary UI process cleanly."""
LOGGER.info("Caught stop operation")
LOGGER.info("Stopping web ui ...")
stop(0)
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@src/ui/temp.py` around lines 37 - 42, Replace the multi-line inline comments
above handle_stop with a concise single-line or short multi-line docstring
inside the function (e.g., describe that handle_stop handles signal shutdown and
why only one argument is accepted), leaving the LOGGER.info call intact; update
the function signature handle_stop(signum, frame) to include the docstring as
the first statement so the function is self-documented and conforms to the
project's docstring/style guidelines.

LOGGER.info("Stopping web ui ...")
stop(0, False)
stop(0)


signal(SIGINT, handle_stop)
Expand Down