Be robust against low-TVL collateral - #78
Open
SupernaviX wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has two changes.
Disabling collateral
For each synthetic, we now read the butane protocol params to find the weights assigned to each collateral. We "disable" any collateral with a weight of 0 (meaning we give it the price
0in any payloads we produce).The point of this change is to have a fast way to disable broken collateral. We won't even try to get a price for any "disabled" collateral, so we don't have to worry about coordinating that price between consumers.
Normalizing Min TVL
The
min_tvlfield in our price configs is now always in units of USD. Before, its units varied depending on which currency we were considering.I have also bumped the min TVL to $500 USD. When deciding prices, we will ignore any DEX pool with less than $500 of TVL.