Skip to content

fix(artifacts): show selected preview filename#3207

Open
yu-wubbalubbadubdub wants to merge 1 commit into
bytedance:mainfrom
yu-wubbalubbadubdub:codex-artifact-preview-filename
Open

fix(artifacts): show selected preview filename#3207
yu-wubbalubbadubdub wants to merge 1 commit into
bytedance:mainfrom
yu-wubbalubbadubdub:codex-artifact-preview-filename

Conversation

@yu-wubbalubbadubdub
Copy link
Copy Markdown
Contributor

Summary

  • Keep the currently selected artifact path available in the preview title dropdown even when it is not present in thread.values.artifacts.
  • This preserves the filename when opening artifacts from present_files / historical message content, matching the write-file preview behavior.
  • Add an artifact-preview E2E regression for a presented file outside the thread artifact list.

Fixes #3192

Validation

  • ./node_modules/.bin/eslint.cmd src/components/workspace/artifacts/artifact-file-detail.tsx tests/e2e/artifact-preview.spec.ts (passed)
  • ./node_modules/.bin/prettier.cmd --check src/components/workspace/artifacts/artifact-file-detail.tsx tests/e2e/artifact-preview.spec.ts (passed)
  • corepack pnpm build (passed; existing Turbopack NFT-list warning from mock artifact route)
  • ./node_modules/.bin/playwright.cmd test tests/e2e/artifact-preview.spec.ts --config .codex-playwright.config.ts (5 passed using system Chrome; default Playwright Chromium download failed in this environment with ECONNRESET)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

产物区文件名展示不一致(前端文件列表渲染 UI 问题)

1 participant