fix: sanitize shell/subprocess call in run_eval.py#3214
Open
orbisai0security wants to merge 1 commit into
Open
fix: sanitize shell/subprocess call in run_eval.py#3214orbisai0security wants to merge 1 commit into
orbisai0security wants to merge 1 commit into
Conversation
Automated security fix generated by OrbisAI Security
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
skills/public/skill-creator/scripts/run_eval.py.Vulnerability
V-007skills/public/skill-creator/scripts/run_eval.py:85Description: Skill scripts use subprocess.Popen and subprocess.run for code execution. The MCP tools handler (tools.py:140) passes unsanitized request arguments that flow into skill script execution without validation. This creates a command injection attack chain where attacker-controlled input from the MCP interface reaches subprocess calls. The project's own TODO.md acknowledges this risk by noting the need to replace subprocess.run in local_sandbox.py.
Changes
skills/public/skill-creator/scripts/run_eval.pyVerification
Automated security fix by OrbisAI Security