Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions frontend/src/core/threads/hooks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,24 @@ export function mergeMessages(
]);
}

export function mergeThreadValues(
previousValues: Partial<AgentThreadState> | undefined,
nextValues: Partial<AgentThreadState> | undefined,
): Partial<AgentThreadState> | undefined {
if (!previousValues) {
return nextValues;
}
if (!nextValues) {
return previousValues;
}

return {
...previousValues,
...nextValues,
todos: nextValues.todos ?? previousValues.todos,
};
}

function getMessagesAfterBaseline(
messages: Message[],
baselineMessageIds: ReadonlySet<string>,
Expand Down Expand Up @@ -559,6 +577,8 @@ export function useThreadStream({
const latestMessageCountsRef = useRef({ humanMessageCount });
const sendInFlightRef = useRef(false);
const messagesRef = useRef<Message[]>([]);
const valuesRef = useRef<Partial<AgentThreadState> | undefined>(thread.values);
const valuesThreadIdRef = useRef<string | null>(threadId ?? null);
const summarizedRef = useRef<Set<string>>(null);
// Track human message count before sending to prevent clearing optimistic
// messages before the server's human message arrives (e.g. when AI messages
Expand Down Expand Up @@ -838,9 +858,17 @@ export function useThreadStream({

// Merge history, live stream, and optimistic messages for display
// History messages may overlap with thread.messages; thread.messages take precedence
const activeThreadId = onStreamThreadId ?? threadId ?? null;
if (valuesThreadIdRef.current !== activeThreadId) {
valuesThreadIdRef.current = activeThreadId;
valuesRef.current = thread.values;
}
const mergedValues = mergeThreadValues(valuesRef.current, thread.values);
valuesRef.current = mergedValues;
const mergedThread = {
...thread,
messages: mergedMessages,
values: mergedValues,
} as typeof thread;

return {
Expand Down
33 changes: 33 additions & 0 deletions frontend/tests/unit/core/threads/message-merge.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {
getVisibleOptimisticMessages,
MAX_CONSECUTIVE_EMPTY_RUN_LOADS,
mergeMessages,
mergeThreadValues,
runMessagesPageHasMore,
shouldAutoContinueOnEmptyRun,
} from "@/core/threads/hooks";
Expand Down Expand Up @@ -486,3 +487,35 @@ test("shouldAutoContinueOnEmptyRun input must use the post-filter visible count,
expect(shouldAutoContinueOnEmptyRun(filteredVisibleCount, 0)).toBe(true);
expect(shouldAutoContinueOnEmptyRun(rawPageSize, 0)).toBe(false);
});

test("mergeThreadValues preserves todos when a later state omits them", () => {
expect(
mergeThreadValues(
{
title: "Thread",
todos: [{ content: "Keep me", status: "in_progress" }],
},
{
title: "Thread",
},
),
).toEqual({
title: "Thread",
todos: [{ content: "Keep me", status: "in_progress" }],
});
});

test("mergeThreadValues allows explicit todo clearing", () => {
expect(
mergeThreadValues(
{
todos: [{ content: "Done", status: "completed" }],
},
{
todos: [],
},
),
).toEqual({
todos: [],
});
});
Loading