Skip to content

User Agentで扱う値を環境変数へ切り出す - #414

Open
arayaalice wants to merge 3 commits into
developfrom
feature/move-useragent-to-env
Open

User Agentで扱う値を環境変数へ切り出す#414
arayaalice wants to merge 3 commits into
developfrom
feature/move-useragent-to-env

Conversation

@arayaalice

@arayaalice arayaalice commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

概要

User Agentで使用するメールアドレスを環境変数へ切り出し、バージョン番号をUser-Agentへ付与するよう変更
また、バージョン番号はbackendのpackage.jsonを参照するよう変更

変更内容

  • User AgentのメールアドレスをUSER_AGENT_EMAILとして環境変数に追加
  • User Agentが環境変数とbackendのpackage.jsonのversionを参照するよう修正
  • 環境変数追加に伴いREADME.mdの内容を変更

共有事項

本対応においては単体テストを正常終了させることを優先
package.jsonoverrides 削除に伴う影響については以下のPRで確認予定
PR: #421

動作確認

USER_AGENT_EMAILがコンテナへ反映されていることを確認

スクリーンショット 2026-08-26 110249

webhook.siteを利用し、送信されるUser Agentヘッダーが以下形式となることを確認

OasisMap/1.2.5 (TISI_WB@ml.tisi.jp)
スクリーンショット 2026-08-26 110506

@k-oizumi-abel

k-oizumi-abel commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

@arayaalice
申し訳ないのですが、方針を再検討することになりましたので修正をお願いできないでしょうか。
整理内容は以下のIssueコメントを確認してください。
#378 (comment)

@arayaalice
arayaalice force-pushed the feature/move-useragent-to-env branch 2 times, most recently from c70d1ac to 86f6940 Compare August 26, 2026 04:20
@arayaalice

Copy link
Copy Markdown
Collaborator Author

@k-oizumi-abel
修正対応が完了いたしました。

@arayaalice
arayaalice force-pushed the feature/move-useragent-to-env branch from 86f6940 to e4c4fbb Compare August 31, 2026 06:24
Comment thread backend/src/happiness/happiness-input.service.ts
Comment thread infra/arm/_env-azure
Comment thread backend/src/happiness/happiness-input.service.ts Outdated
Comment thread backend/package.json
Comment thread backend/tsconfig.json Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread backend/src/happiness/happiness-input.service.ts
Comment thread backend/src/happiness/happiness-input.service.spec.ts Outdated
@arayaalice
arayaalice force-pushed the feature/move-useragent-to-env branch 4 times, most recently from 31a2277 to d454c07 Compare September 1, 2026 01:23
Comment thread backend/package.json Outdated
@arayaalice
arayaalice force-pushed the feature/move-useragent-to-env branch 3 times, most recently from f92ec7c to c82d7dd Compare September 1, 2026 08:42
@arayaalice
arayaalice force-pushed the feature/move-useragent-to-env branch from c82d7dd to 5cd782a Compare September 1, 2026 08:45
@arayaalice
arayaalice force-pushed the feature/move-useragent-to-env branch from 5cd782a to 2759265 Compare September 1, 2026 08:51
@arayaalice
arayaalice force-pushed the feature/move-useragent-to-env branch from 2759265 to bf36199 Compare September 2, 2026 01:29
@k-oizumi-abel
k-oizumi-abel removed the request for review from mmoriwakiAbel September 2, 2026 04:26
@k-oizumi-abel
k-oizumi-abel marked this pull request as ready for review September 2, 2026 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants