Skip to content

src: allow for year = 0; BC --> BCE; facilitate Astronomical and (B)CE timeline #1580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
evgaster wants to merge 17 commits into
base: stable
Choose a base branch
from
Open

src: allow for year = 0; BC --> BCE; facilitate Astronomical and (B)CE timeline #1580

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
94668b8
src: allow for year = 0
evgaster Nov 28, 2025
7cb41e4
src: change BC to B(efore) C(ommon) E(ra)
evgaster Nov 28, 2025
ae688aa
src: Better handling of the BCE - CE timeline
evgaster Nov 29, 2025
fc6e133
src: correct the label for the DateMenu
evgaster Nov 30, 2025
2f713b5
doc: improve Date and Time documentation
evgaster Nov 30, 2025
f720313
Update system.md
evgaster Nov 30, 2025
26def6c
Update system.md
evgaster Nov 30, 2025
3f0a82e
Update system.md
evgaster Nov 30, 2025
8bf97b5
Update system.md
evgaster Nov 30, 2025
82a03f4
doc: further improve Date and Time documentation
evgaster Dec 2, 2025
08fc3bc
src: change Julian date conversion to SOFA functions.
evgaster Dec 14, 2025
203cbba
Merge branch 'c3d:stable' into issue-1538
evgaster Dec 21, 2025
cafb1ba
src: comply with SOFA Copyright and license
evgaster Dec 23, 2025
0e86740
doc: Improve Date and Time documentation
evgaster Dec 27, 2025
410086f
src: Add JDN error handling.
evgaster Jan 9, 2026
45be955
doc: improvements to Date and Time documentation
evgaster Jan 9, 2026
b70071a
Improvements after review by @c3d.
evgaster Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions src/datetime.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ uint to_date(object_p dtobj, dt_t &dt, tm_t &tm, bool error)

const uint days[12] = { 31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31 };
bool bisext = m == 2 && y % 4 == 0 && (y % 100 != 0 || y % 400 == 0);
if (m < 1 || m > 12 || d < 1 || d > days[m-1] + bisext || y == 0)
Comment thread
evgaster marked this conversation as resolved.
if (m < 1 || m > 12 || d < 1 || d > days[m-1] + bisext)
{
if (error)
rt.invalid_date_error();
Expand Down Expand Up @@ -624,11 +624,6 @@ size_t render_date(renderer &r, algebraic_g date)
uint month = date->as_uint32(0, false) % 100;
date = date / factor;
uint year = date->as_uint32(0, false);
if (year == 0)
{
rt.invalid_date_error();
return 0;
}

char mname[4];
if (Settings.ShowMonthName() && month >=1 && month <= 12)
Expand Down Expand Up @@ -660,7 +655,7 @@ size_t render_date(renderer &r, algebraic_g date)
case 3: r.printf("%s%c%s%c%u", ytext, sep, mname, sep, day); break;
}
if (neg)
r.printf(" BC");
r.printf(" BCE");
Comment thread
evgaster marked this conversation as resolved.
Outdated

if (time && !time->is_zero())
{
Expand Down
2 changes: 1 addition & 1 deletion src/tests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10134,7 +10134,7 @@ void tests::date_operations()
.expect("2 460 938");
step("Converting from a Julian day number to a date")
.test(CLEAR, "1 000 000", ENTER, ID_DateFromJulianDayNumber)
.expect("Tue 21/Oct/1975 BC");
.expect("Tue 21/Oct/1975 BCE");
step("Adding invalid dates")
.test(CLEAR, "1 2 DATE+", ENTER)
.error("Invalid date");
Expand Down