cmd: colored error message in WrapCommandFuncForCobra (#7760)#7768
Open
u5surf wants to merge 3 commits into
Open
cmd: colored error message in WrapCommandFuncForCobra (#7760)#7768u5surf wants to merge 3 commits into
u5surf wants to merge 3 commits into
Conversation
Signed-off-by: Y.Horie <u5.horie@gmail.com>
Member
|
I think this is probably fine but it does sorta mean the error message is a bit less machine readable since it's not just plain text on the final line, but I think that's probably not a big deal. Do you mind taking a screenshot of how it looks for you before and after? Thanks! |
Contributor
Author
I took screenshots to compare before to after. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assistance Disclosure
I consulted Claude code for the issue, but I coded it myself because it is easy to fix, but Claude helped me to generate some code comments.
Fixes: #7760
WrapCommandFuncForCobra has not colored error messages. So We should wrap error messages with caddy.Log().Error.