feat(api): refactor additional findings resolvers - #7534
Open
lcampbell2 wants to merge 8 commits into
Open
Conversation
lcampbell2
commented
Aug 20, 2026
lcampbell2
commented
Collaborator
- refactors additionalFindings object to match fields established in feat: additional findings processor #7518
- refactors Domain.additionalFindings loader to a Relay connection and adds pagination, sorting, and filtering support
- removes legacy top-25 additional findings query code
FestiveKyle
reviewed
Aug 28, 2026
| type: GraphQLString, | ||
| description: `The date the finding was discovered.`, | ||
| resolve: ({ PortStateLastSeen }) => PortStateLastSeen, | ||
| occurenceCount: { |
Collaborator
There was a problem hiding this comment.
Typo occurenceCount/occurrenceCount leads to duplicate document fields and API query failure
| type: GraphQLString, | ||
| description: '', | ||
| resolve: ({ WebComponentFirstSeen }) => WebComponentFirstSeen, | ||
| description: 'NATS channel subject of the scanner.', |
Collaborator
There was a problem hiding this comment.
Should this be the domain/entity name, not the NATS channel?
| type: GraphQLString, | ||
| description: `The URL of the web component.`, | ||
| resolve: ({ WebComponentName }) => WebComponentName, | ||
| description: 'Name of the domain the finding is attributed to.', |
Collaborator
There was a problem hiding this comment.
I think the findings processor sets this to the arango domain._id:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.