Rename segment_buffer file into the new segment_sink name - #1572
Merged
Conversation
Florent-Bouisset
approved these changes
Oct 22, 2024
We changed the name of classes from *SegmentBuffer to *SegmentSink but didn't actually update the file names. This is now done.
peaBerberian
force-pushed
the
misc/segment_buffer_to_segment_sink
branch
from
October 22, 2024 13:05
4932304 to
8fcf2f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this was part of the #1413 PR, which was a collection of unrelated improvements. I Chose to open individual pull requests instead so it's easier to review and discuss.
We changed the name of classes from *SegmentBuffer to *SegmentSink but didn't actually update the file names. This is now done.