Skip to content

[WIP] Do not rely on vitest for memory tests #1791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
peaBerberian wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[WIP] Do not rely on vitest for memory tests #1791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
/tests/performance/control-current.js
/tests/performance/package.json
/tests/performance/package-lock.json
/tests/simple-test-bundle.js

/dist/

Expand Down
6 changes: 2 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,7 @@
"test:integration:firefox": "npm run --silent test:integration:notice && cross-env BROWSER_CONFIG=firefox vitest run tests/integration/scenarios",
"test:integration:firefox:watch": "npm run --silent test:integration:notice && cross-env BROWSER_CONFIG=firefox vitest watch tests/integration/scenarios",
"test:integration:notice": "echo \"~~~ ⚠️ NOTICE ⚠️\n~~~ Tests have two dependencies: a local RxPlayer build and ffmpeg.\n~~~ Make sure you:\n~~~ 1. Have an ffmpeg executable in your path and,\n~~~ 2. You built an up-to-date RxPlayer through the \\`build\\` npm script.\n\"",
"test:memory": "npm run --silent test:integration:notice && cross-env BROWSER_CONFIG=chrome vitest run tests/memory",
"test:memory:chrome:watch": "npm run --silent test:integration:notice && cross-env BROWSER_CONFIG=chrome vitest watch tests/memory",
"test:memory": "npm run --silent test:integration:notice && node ./tests/simple-test-runner.mjs ./tests/memory/index.test.js",
"test:performance": "node ./tests/performance/run.mjs",
"test:unit": "vitest --config vitest.config.unit.mjs",
"types": "tsc --noEmit --project .",
Expand Down Expand Up @@ -287,8 +286,7 @@
"test:unit -- --watch": "Launch unit tests and restart them each one of its file changes"
},
"Memory tests (test memory usage to avoid memory leaks, call the `build` script BEFORE running them)": {
"test:memory": "Launch memory tests",
"test:memory:chrome:watch": "Launch memory tests in Chrome each times the files update"
"test:memory": "Launch memory tests"
},
"Performance tests (test against performance regressions on some key scenarios)": {
"test:performance": "Launch performance tests on a Chrome browser",
Expand Down
2 changes: 1 addition & 1 deletion tests/memory/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { expect, describe, afterEach, test } from "vitest";
import { expect, describe, afterEach, test } from "../simple-test-lib";
// TODO: rely on `dist` instead
import RxPlayer from "../../src";
import VideoThumbnailLoader, {
Expand Down
Loading
Loading