dash: Do not request undeclared initialization segments - #1886
Open
peaBerberian wants to merge 1 commit into
Open
dash: Do not request undeclared initialization segments#1886peaBerberian wants to merge 1 commit into
peaBerberian wants to merge 1 commit into
Conversation
|
✅ Automated performance checks have passed on commit DetailsPerformance tests 1st run outputNo significative change in performance for tests:
|
peaBerberian
force-pushed
the
fix-null-init-segment
branch
from
September 1, 2026 09:38
c235782 to
e23dc04
Compare
|
✅ Automated performance checks have passed on commit DetailsPerformance tests 1st run outputNo significative change in performance for tests:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While fixing some integration tests of #1884, I noticed that we had poor handling of some DASH contents without an initialization segment.
For some, instead of skipping it, we still requested a URL corresponding to the
BaseURL.To fix it I clarified the semantics of the private
initializationstate in indexes (SegmentList,SegmentTemplate,SegmentTimeline...).Previously it was optional, and potentially
undefinedbut theundefinedcase's semantics was never documented. Now I propose to make itnullwhen not set and explicitly document that it means that this Representation has no initialization segment available.