Repository navigation
refactor(spring): drop ChannelSendOperator from the DataSource return-value handler - #30
Merged
Merged
Conversation
…f via ChannelSendOperator The return-value handler stored the encoded content flow into the response AtomicReference inside a Spring WebFlux ChannelSendOperator. That operator is an HTTP-response-writing idiom (buffer the first element to decide status/headers) and pulled spring-web into the messaging starter. The handler's only contract is to set the response reference before its Mono completes, and the flow is cold and collected later by DataSourceServerBootstrap — so a direct synchronous set plus Mono.empty() is equivalent and drops the spring-web coupling. Also removes the now-unneeded org.springframework.lang.Nullable usage (the parameter is non-null after the simplification).
rossdanderson
force-pushed
the
refactor/payload-return-value-handler
branch
from
May 29, 2026 15:21
972e7e5 to
621149a
Compare
rossdanderson
added a commit
that referenced
this pull request
Jun 25, 2026
* feat: upgrade to Spring Boot 4.0 with Jackson 3 as the default - Bump to Spring Boot 4.0.6 / Kotlin 2.2.21; Jackson 3 versions come from the BOM. - util: Jackson 3 becomes the runtime default (api), Jackson 2 is compileOnly; createDataSource defaults to the Jackson 3 handler. - spring starter: JsonHandler bean prefers Jackson 3, falls back to Jackson 2 (spring-boot-jackson2); DataMessageMapping doc references tools.jackson. - spring tests use Logback only (drop slf4j-simple) with a quiet logback-test.xml; add kotest SpringExtension + a context test asserting the Jackson 3 handler. - Docs: README compatibility table + MIGRATION.md (2.x/Boot 3.5 -> 3.x/Boot 4.0). Depends on the ChannelSendOperator removal (PR #30) landing on main first. * chore: bump Kotlin JPS plugin to 2.3.20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets the DataSource response flow directly in
DataSourcePayloadReturnValueHandlerinstead of routing it through a WebFluxChannelSendOperator. The operator was an HTTP-response idiom that only pulledspring-webinto the messaging starter for no benefit — the flow is cold and collected later, so a synchronous set plusMono.empty()is equivalent.One file changed, no public API change.