Upgrade commander to v15#235
Open
captbaritone wants to merge 1 commit into
Open
Conversation
Commander v15 drops support for Node.js < 22.12.0, so bump Grats' minimum Node version to >=22.12 and drop Node 20.x from the CI matrix (publish job moved to 22.x). No source changes were needed; the CLI API we use is unchanged and --help/--version output is identical. - package.json: commander ^15.0.0, engines.node >=22.12 <=24 - pnpm-lock.yaml: regenerated for commander 15.0.0 - .github/workflows/ci.yaml: drop Node 20.x, publish job -> 22.x - changelog: note breaking Node requirement + commander bump
❌ Deploy Preview for grats failed. Why did it fail? →
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades
commanderfrom v14 to v15.Commander v15 dropped support for Node.js
< 22.12.0, so this bumps Grats' minimum Node version accordingly.Changes
package.json:commander→^15.0.0;engines.node→>=22.12 <=24pnpm-lock.yaml: updated to commander15.0.0.github/workflows/ci.yaml: dropped Node20.xfrom the test matrix; publish job moved from Node20.x→22.x>=22.12.0) and an Improvements note for the commander bumpBreaking change
Grats now requires Node.js >=22.12.0 (was
>=20). This is a consequence of commander v15's own Node requirement.Verification
Command,.version(),.option(),.action(),.parse()) is unchanged in v15.grats --help,grats --version, andgrats locate --helpproduce identical output under v14 and v15.tsc --buildpasses.customScalarSerializationis unrelated to this change — it reproduces onmainwithout these edits and is being investigated separately.)