Repository navigation
fix(data-table): add headers to table state to prevent brief mismatch with rows (#22714)
#23114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
benjamin-t-santos
wants to merge
21
commits into
carbon-design-system:main
from
benjamin-t-santos:data-table-header-flicker-fix
+124
−7
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
6580796
fix: headers in table state to fix desync w/ rows
benjamin-t-santos 19e48da
fix: revert white space changes
benjamin-t-santos c5af495
Merge branch 'main' into data-table-header-flicker-fix
benjamin-t-santos 3513cc4
fix: compare complete headers (not just keys)
benjamin-t-santos 525c187
Merge branch 'main' into data-table-header-flicker-fix
benjamin-t-santos 116212e
fix: use copy of headers for data table state
benjamin-t-santos 30e3f67
fix: create new headers elements for states, better test coverage
benjamin-t-santos 2a9ca56
Merge branch 'main' into data-table-header-flicker-fix
benjamin-t-santos 2e5e290
Merge branch 'main' into data-table-header-flicker-fix
benjamin-t-santos 13c5967
Merge branch 'main' into data-table-header-flicker-fix
benjamin-t-santos b07d255
Update getDerivedStateFromProps-test.js
benjamin-t-santos f2eb65a
Merge remote-tracking branch 'upstream/main' into data-table-header-f…
benjamin-t-santos a11b94c
fix: add coverage for updated derived props via mutation
benjamin-t-santos 3b8c861
chore: verify DataTable render props use same header/row versions
benjamin-t-santos 38431a8
Merge branch 'main' into data-table-header-flicker-fix
benjamin-t-santos db902f9
fix: use length for last call
benjamin-t-santos 7ca9f41
Merge branch 'main' into data-table-header-flicker-fix
benjamin-t-santos a9c5891
Merge branch 'main' into data-table-header-flicker-fix
kennylam 5757a0a
Merge branch 'main' into data-table-header-flicker-fix
benjamin-t-santos 8b02e06
Merge branch 'main' into data-table-header-flicker-fix
heloiselui 229ff18
Merge branch 'main' into data-table-header-flicker-fix
benjamin-t-santos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.