Repository navigation
fix(DataTable): don't match empty or object cell values when filtering #23993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
officialasishkumar
wants to merge
4
commits into
carbon-design-system:main
Choose a base branch
from
officialasishkumar:fix/23990-datatable-filter-empty-cells
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+127
−7
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
ebc5d4b
fix(DataTable): don't match empty or object cell values when filtering
officialasishkumar 1c0b098
fix(DataTable): skip objects without toString when filtering
officialasishkumar 91f88a6
Merge remote-tracking branch 'origin/main' into fix/23990-datatable-f…
officialasishkumar b04de82
fix(DataTable): limit default filter to primitive cell values
officialasishkumar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could the value be converted to a string once instead? Cross realm plain objects can still pass this check, and accessing
toStringhere and again duringString(value)can invoke a getter twice. String conversion can also throw an error.https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Execution_model#realms
Edit: Hmm, even if the value is converted to a string once, the conversion can still invoke inherited methods. Could the default filter limit string conversion to explicitly supported types instead of using
prototypechecks?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. It now converts only strings, numbers and bigints to text and ignores everything else, so no toString is ever invoked (officialasishkumar@b04de82).