Skip to content

test: migrate React tests to TypeScript - #24068

Open
adamalston wants to merge 2 commits into
carbon-design-system:mainfrom
adamalston:19011-typescript-tests-2
Open

adamalston wants to merge 2 commits into
carbon-design-system:mainfrom
adamalston:19011-typescript-tests-2

Conversation

@adamalston

Copy link
Copy Markdown
Contributor

Partially addresses #19011

Migrated the Public API, SCSS, SSR, and React entrypoint tests to TypeScript.

Changelog

Changed

  • Migrated the Public API, SCSS, SSR, and React entrypoint tests to TypeScript.

Removed

  • Removed the unused React Router example tests.

Testing / Reviewing

yarn test packages/react

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Followed the
    required v12 migration documentation
    for any code change that affects v12, or struck through this item because
    the PR does not affect v12
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide.

@netlify

netlify Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for v12-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9f6783f
🔍 Latest deploy log https://app.netlify.com/projects/v12-carbon-react/deploys/6afb4077447381578e75e011
😎 Deploy Preview https://deploy-preview-24068--v12-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for v12-carbon-web-components ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9f6783f
🔍 Latest deploy log https://app.netlify.com/projects/v12-carbon-web-components/deploys/6afb407815013cfa8c155d1a
😎 Deploy Preview https://deploy-preview-24068--v12-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 9f6783f
🔍 Latest deploy log https://app.netlify.com/projects/carbon-elements/deploys/6afb40785adb3ba079c519c9
😎 Deploy Preview https://deploy-preview-24068--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9f6783f
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/6afb40775a5d817a310c4e05
😎 Deploy Preview https://deploy-preview-24068--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@adamalston
adamalston marked this pull request as ready for review November 16, 2026 17:42
@adamalston
adamalston requested review from a team as code owners November 16, 2026 17:42
@netlify

netlify Bot commented Nov 16, 2026

Copy link
Copy Markdown

✅ Deploy Preview for v11-carbon-web-components ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9f6783f
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/6afb407768f92bde4b85f09a
😎 Deploy Preview https://deploy-preview-24068--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@adamalston
adamalston deployed to @carbon/react storybook preview November 16, 2026 17:49 — with GitHub Actions Active
@codecov

codecov Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.71%. Comparing base (657756f) to head (9f6783f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24068      +/-   ##
==========================================
- Coverage   90.76%   90.71%   -0.06%     
==========================================
  Files         817      817              
  Lines       79816    79823       +7     
  Branches    10420    10446      +26     
==========================================
- Hits        72446    72409      -37     
- Misses       7171     7209      +38     
- Partials      199      205       +6     
Flag Coverage Δ
main-packages 88.12% <ø> (+<0.01%) ⬆️
web-components 91.47% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch was successfully deployed

1 active deployment
@carbon/react storybook preview — 9f6783f9 Deployed Nov 16, 2026 by adamalston via react-storybook-preview #45295
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant