ui: Update addons to strict template mode versions - #5648
Draft
backspace wants to merge 4 commits into
Draft
Conversation
Contributor
Preview deploymentsHost Test Results 1 files 1 suites 2h 30m 38s ⏱️ Results for commit af7ab0e. For more details on these errors, see this check. Realm Server Test Results 1 files ± 0 1 suites +1 15m 27s ⏱️ + 15m 27s Results for commit af7ab0e. ± Comparison against earlier commit 76a480c. |
backspace
force-pushed
the
boxel-ui-strict-deps-cs-12382
branch
from
July 30, 2026 22:36
d5fe6de to
69ca7c7
Compare
backspace
force-pushed
the
boxel-ui-flatten-cs-12379
branch
from
July 30, 2026 22:55
e5f50e6 to
cb55e60
Compare
Known failing: the dropdown auto-close and picker select-all-throw tests (402/404) — dep-behavior fallout under ember-basic-dropdown 9 and ember-power-select 9, to be fixed on this branch. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ember-basic-dropdown 9 removed its boot-time initializer, so its content teleported to a nonexistent destination and silently rendered nothing; the test harness now points it inside the test root via setConfig. The picker select-all validation is extracted to a pure function and asserted directly, since a constructor throw aborts the glimmer render in a way rendering tests cannot recover from. Partial power-select 9 type adaptation included; the remaining type errors are tracked in CS-12382. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Select moved to ember-power-select/types and went generic; the custom trigger/selected-item/after-options signatures now inherit or thread power-select's generic shapes instead of redeclaring PS8-era ones, and selected-item follows the upstream @selected arg naming. Component-slot defaults are pinned to the expected member types where glint cannot match generic or curried components against power-select's unions. Direct mutations of the now-readonly select.selected are replaced with actions.select. Host and realm call sites still carry ~41 errors from onChange handlers not accepting undefined-on-clear; tracked in CS-12382. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
backspace
force-pushed
the
boxel-ui-strict-deps-cs-12382
branch
from
July 30, 2026 22:56
69ca7c7 to
76a480c
Compare
ember-basic-dropdown 9 peer-resolves @embroider/macros 1.20.x from boxel-ui, while host and boxel-icons still resolved 1.16.13. Embroider refuses to build when a v1 addon sees a different macros copy than the consuming app, so the host dist build failed. Pin every workspace consumer to ^1.20.5 so a single copy resolves. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.