Proper UMD export and npm building - #30
Open
jasonkarns wants to merge 5 commits into
Open
Conversation
Author
gitignore node_modules (umd) and the built assets. But instruct npm to include the build assets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source is a proper CommonJS module.
UMD utility generates the wrapping UMD wrapper and is uglified.
Both of these steps are done via npm's
preparestep,which is run automatically during the pack/publish lifecycle and
during bare installs (ie, when installed as a git-dep).
Sourcemap is also generated to accompany the uglified output.
The built assets are ignored from git (generated assets shouldn't be version controlled).
Npm is instructed to include the appropriate built assets in the package tarball.
Package-lock is added as per npm5.